Develop #192
Closed
Develop #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating the button and a sample template for Export to PDF refs: 10244
Fetching insight in action for exporting to PDF and planning steps for action in comments refs: 10244
Adding service function to find a list of all available templates refs: 10244
Filter list of template titles to only display those that include the insights name. refs: 10244
Get name of insight to filter templates available to choose from for exporting to PDF refs: 10244
Use the category variable in the findTemplates template service function to filter templates shown to only show templates including the insight class name and PDF in the title refs: 10244
Removing unnecessary line and undefined, unnecessary variable. refs: 10244
Changes to find correct template to display in list, and comments for more changes needed refs: 10244
Changing drop-down into multi-col form and adding code to be edited for use in yet to be created POSt function refs: 10244
making get and post functions for exporting to PDF refs: 10244
Changing export to PDF button from link to another page to a popup box refs: 10244
Sending data to the POST function, rendering the insight data using the template selected, and redirecting back to runInsight refs: 10244
Correct url in postUrl refs: 10244
Update the variables used in POST to get the values from the multiColForm $template_list refs: 10244
Creating and correcting variables to get correct data in the post function for rendering in the template and exporting to PDF refs: 10244
Checking how the exportpdf function that the report module uses works. refs: 10244
Changing the exportpdf function to use the run_data variable instead of rows refs: 10244
changing exportphp function to use run_data refs: 10244
Checking new variables for exportpdf function refs: 10244
Editing code to use run_data in exportpdf service function refs: 10244
Making selection of a template for exporting to a PDF mandatory refs: 10244
Organising template and data for the table for exporting to PDF refs: 10244]
Change where user is told choosing a template is required refs: 10244
Fixing small errors in the export PDF action and service function that VSCode had flagged with red underlines refs: 10244
remove console log lines which were added for the purpose of testing refs: 10244
…ure/InsightTemplates
Old commented out code removed refs: 10244
Updating jQuery code to Vanilla JavaScript refs: 10244
feat: insight templates
* fix: check for arrays and objects added a check for object or arrays as array_key_esists is depreciated for use on objects causing warnings refs: 10244 * feat: requested changes Changes requested on GitHub to tread $fields as object and use the allow operator instead of the array operator refs: 10244 * fix: requested changes Changes requested on GitHub to tread $fields as object and use the allow operator instead of the array operator refs: 10244 * fix: remove duplications deleted duplicated lines refs: 10244 * fix: check is fields object add an elseif to check if the fields variable is an object refs: 10244 Co-authored-by: Taliesin Millhouse <[email protected]>
Working to fix issue with foundation function refs: 10151
Converting Vanilla JavaScript code to jQuery so that foundation function will work refs: 10151
Removing the duplicate of the select option appearing twice in the drop down wen choosing a template for PDF export [body footer?] refs: 10151
remove testing code and unnecessary comments refs: 10151
* Rough cut proof, WIP * Integral patches * H-Scroll wide tables * Fix default PDF heading layout * Remove experimental code for simple implementation * Confirmed use case for core_layout_tpl * Portrait & Landscape on Insights pdf * Removed some lint Co-authored-by: D.Crannaford <[email protected]>
feat: Flush recent fixes
feat: Insights JavaScript Fix
* ! Removed magic __get functions from Web, DbObject and DbService * ! Removed request() from Web in lieu of the Request static class * ! Also removed cmp_weights(), sendFile(), service(), _callPreListeners() and _callPostListeners() from Web * Commented out CachedTemplate in Web, expected to be removed in future version * Added support for code sniffing in Github actions over multiple PHP versions * Migrated all usages of magic $w::__get method to the proper DbService::getInstance($w) function * ! Removed unused shorthand _tn and _cn functions from DbObject * ! Removed snake_case functions in lieu of the matching camelCase counterparts from DbPDO * ! Removed setMissingResponse() from JsonResponse * ! Removed getFileExtension(), lookupForSelect() , getStateSelectArray(), formatMoney(), returncorrectdates(), AESencrypt() and AESdecrypt() from functions.php * ! Updated FluentPDO to latest version * ! Removed all Lookup functions from AdminService (use LookupService instead) * Added missing functions to LookupService from point above * Removed checkPassword() from User model * Removed $update_salt flag from encryptPassword() function in User model * Removed getNewMessages() from ChannelService * Moved from Zend to Laminas (still Zend, just new name) * Added ability for migrations run on CLI to print errors to screen * Updated some composer dependencies to latest version * Updated development Docker container to Ubuntu 20.04 LTS * Fixed type bugs due to move to PHP 8.x * Fixed static service instantiation for PHP 8.x * Fixed some code formatting * Started adding property types to Web * Backwards breaking changes to cmfive core: Potentially breaking changes: * Updated FluentPDO to add support for PHP8.1 Notices: * Removed user account creation hook listener in the Inbox module Post test updates * Corrected reference to DbPDO * Tidied up some code that was commented * Updated workflow to remove reliance on python set up scripts * Updates to CI scripts Co-authored-by: Adam Buckley <[email protected]> Co-authored-by: DerekCrannaford <[email protected]>
### General features/updates * Added CountryService methods * Added AdminService::getCountryWhere() method. * Added missing returns to User::deleted() method. * Added profile security vue component * Added Request::array() method * Added helper functions to Language model * Added ability to hide application name on login * Added better support for enabling/disabling help and search functionality * Added support for filtering uploadings based on file extension (checks mimetype) * Added country and language seed * Added login attempt tracking with account lock * Added password strength enforcement * Added automatic logout after inactivity * Added customisable login field labels * Added persistent banner for when mfa is required but user doesn't have it on * Added MFA insight * Added pagination to user list * Added antivirus service * Added support for test_mode banner * Updated tests * Updated .github/ci.yml * Fixed History class doubling up some endpoints * Fixed several typos. * Fixed issue with memory usage of uploads * Fixed issue with insights * Fixed usage of deprecated sass compiler function * Fixed issue with short login field size * Fixed more issues from PHP 8.1 migration ### New design features * Added ability to compile assets in project modules * Added new base template designs * Added dark mode * Added data-link-target support * Added dom update event bus, * Added new Bootstrap html functions * Added basic animation support * Added support for multifile upload, inputs. Fix a bug with multiple attachments in FileService * Added support for quill, added some helper functions * Removed build artifacts, added multiselect support, changed identifier of Language to 3 letter code * Added pagination styles, updated inputwithother * Added form class support to html, updated alerts to be in line with bootstraps styles * Added responsive table * Added persistence of theme settings via new user setting feature * Added 'dataCard' element * Added splash overly for long processes * Added support for bootstrap tooltips Co-authored-by: Adam Buckley <[email protected]> Co-authored-by: D.Crannaford <[email protected]> Co-authored-by: Dane Evans <[email protected]> Co-authored-by: Taliesin Millhouse
Co-authored-by: Derek Crannaford <[email protected]>
* Language migrations if NOTABLE exists vs importDB * fixes for php8.1 and mysql8 migration * Db column, (_Typo, strip_tags_STR * Hide PolyFill dev logging * Small fixes, null strings and wrong typing * Some stray non-conditional STRPOS * Conformed Stray ->log-> --------- Co-authored-by: D.Crannaford <[email protected]> Co-authored-by: Carsten Eckelmann <[email protected]> Co-authored-by: Robert Lockerbie <[email protected]>
* Created move action for timelogs * Fixing display of duration for active timelogs * Add error checking on move_POST
* Merge develop into master (#171) PHP 8.1 changes * ! Removed magic __get functions from Web, DbObject and DbService * ! Removed request() from Web in lieu of the Request static class * ! Also removed cmp_weights(), sendFile(), service(), _callPreListeners() and _callPostListeners() from Web * Commented out CachedTemplate in Web, expected to be removed in future version * Added support for code sniffing in Github actions over multiple PHP versions * Migrated all usages of magic $w::__get method to the proper DbService::getInstance($w) function * ! Removed unused shorthand _tn and _cn functions from DbObject * ! Removed snake_case functions in lieu of the matching camelCase counterparts from DbPDO * ! Removed setMissingResponse() from JsonResponse * ! Removed getFileExtension(), lookupForSelect() , getStateSelectArray(), formatMoney(), returncorrectdates(), AESencrypt() and AESdecrypt() from functions.php * ! Updated FluentPDO to latest version * ! Removed all Lookup functions from AdminService (use LookupService instead) * Added missing functions to LookupService from point above * Removed checkPassword() from User model * Removed $update_salt flag from encryptPassword() function in User model * Removed getNewMessages() from ChannelService * Moved from Zend to Laminas (still Zend, just new name) * Added ability for migrations run on CLI to print errors to screen * Updated some composer dependencies to latest version * Updated development Docker container to Ubuntu 20.04 LTS * Fixed type bugs due to move to PHP 8.x * Fixed static service instantiation for PHP 8.x * Fixed some code formatting * Started adding property types to Web * Backwards breaking changes to cmfive core: Potentially breaking changes: * Updated FluentPDO to add support for PHP8.1 Notices: * Removed user account creation hook listener in the Inbox module Post test updates * Corrected reference to DbPDO * Tidied up some code that was commented * Updated workflow to remove reliance on python set up scripts * Updates to CI scripts ### General features/updates * Added CountryService methods * Added AdminService::getCountryWhere() method. * Added missing returns to User::deleted() method. * Added profile security vue component * Added Request::array() method * Added helper functions to Language model * Added ability to hide application name on login * Added better support for enabling/disabling help and search functionality * Added support for filtering uploadings based on file extension (checks mimetype) * Added country and language seed * Added login attempt tracking with account lock * Added password strength enforcement * Added automatic logout after inactivity * Added customisable login field labels * Added persistent banner for when mfa is required but user doesn't have it on * Added MFA insight * Added pagination to user list * Added antivirus service * Added support for test_mode banner * Updated tests * Updated .github/ci.yml * Fixed History class doubling up some endpoints * Fixed several typos. * Fixed issue with memory usage of uploads * Fixed issue with insights * Fixed usage of deprecated sass compiler function * Fixed issue with short login field size * Fixed more issues from PHP 8.1 migration ### New design features * Added ability to compile assets in project modules * Added new base template designs * Added dark mode * Added data-link-target support * Added dom update event bus, * Added new Bootstrap html functions * Added basic animation support * Added support for multifile upload, inputs. Fix a bug with multiple attachments in FileService * Added support for quill, added some helper functions * Removed build artifacts, added multiselect support, changed identifier of Language to 3 letter code * Added pagination styles, updated inputwithother * Added form class support to html, updated alerts to be in line with bootstraps styles * Added responsive table * Added persistence of theme settings via new user setting feature * Added 'dataCard' element * Added splash overly for long processes * Added support for bootstrap tooltips * Various spot patches from 8.1 testing (#172) * Fix: Patching From Module Observations (#173) * Language migrations if NOTABLE exists vs importDB * fixes for php8.1 and mysql8 migration * Db column, (_Typo, strip_tags_STR * Hide PolyFill dev logging * Small fixes, null strings and wrong typing * Some stray non-conditional STRPOS * Conformed Stray ->log-> Co-authored-by: Alice <[email protected]> Co-authored-by: Taliesin Millhouse <[email protected]> Co-authored-by: Alice Hutley <[email protected]> Co-authored-by: DerekCrannaford <[email protected]> Co-authored-by: D.Crannaford <[email protected]> Co-authored-by: Adam Buckley <[email protected]> Co-authored-by: Dane Evans <[email protected]> Co-authored-by: Carsten Eckelmann <[email protected]> Co-authored-by: Robert Lockerbie <[email protected]> * core Tests against new PHP8 master on boilerplate * Correct ci boilerplate branch --------- Co-authored-by: Adam Buckley <[email protected]> Co-authored-by: Alice <[email protected]> Co-authored-by: Taliesin Millhouse <[email protected]> Co-authored-by: Alice Hutley <[email protected]> Co-authored-by: D.Crannaford <[email protected]> Co-authored-by: Adam Buckley <[email protected]> Co-authored-by: Dane Evans <[email protected]> Co-authored-by: Carsten Eckelmann <[email protected]> Co-authored-by: Robert Lockerbie <[email protected]>
* First cut namespace changes * Check remote can push * Patched task test * Update CI Selenium container reference * Patch deprecated sanitiser * Bump version on ci uploadArtifact action * Bump ci for core 8.1 explicit from Composer --------- Co-authored-by: Derek Crannaford <[email protected]>
DerekCrannaford
previously approved these changes
May 21, 2023
* Bump config and block out legacy code * Fix revealed typo * Restore dropped var * Clarify deprecatino in comments --------- Co-authored-by: Derek Crannaford <[email protected]>
Co-authored-by: D.Crannaford <[email protected]>
* First cut at arbitray count and catch * Make default be all files moved --------- Co-authored-by: D.Crannaford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Changelog
refs:
issues:
Other Information
Docs pull request: