-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/insights reporting bootstrap5 #195
Conversation
This is a feature, but PR is like a 'fix'? |
Changed PR to merge with develop |
Bring Insight Report Bootstrap up to date with dev
…oftware/cmfive-core into feature/InsightsReportingBootstrap5
…ap5' into feature/InsightsReportingBootstrap5
I just realised this code is now redundant and/or not used anywhere - closing |
Checklist
Description
Convert the existing Insights module to support bootstrap5
Changelog
Added display_overlay property. Enables the form to be opened with or without “data_show_overlay”
Set using the form->open() method
system/classes/html/form.php
Additional parameter to enable the displaying of the “data_show_overlay” or not - default value is true
Modify $sl_class to "form-select" in mutlicolform when $type = ‘select’
system/classes/HtmlBootstrap5.php
system/templates/base/package-lock.json
Modified to use the bootstrap5 date picker
system/modules/admin/models/AuditInsight.php
system/modules/task/models/MyTaskTimeInsight.php
Modified to call HtmlBootstrap5 objects
system/modules/insights/actions/index.php
system/modules/insights/actions/viewInsight.php
system/modules/insights/actions/runInsight.php
system/modules/insights/templates/runInsight.tpl.php
Call to HtmlBootstrap5 objects, including multicoloured form call with dataOverlay parameter set to false
system/modules/insights/actions/export/bindpdf.php
Removed as no template file required by bindpdf.php
system/modules/insights/templates/export/bindpdf.tpl.php
refs:
issues:
Other Information
Two branches depend upon this branch:
crm feature/InsightsReportingBootstrap5
bridge_cmfive_module feature/InsightsReportingBootstrap5
Docs pull request: