Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/insights reporting bootstrap5 #195

Closed
wants to merge 30 commits into from

Conversation

2piJareem
Copy link
Contributor

@2piJareem 2piJareem commented Jun 28, 2023

Checklist

  • I'm using the correct PHP Version (8.1).
  • I've added comments to any new methods I've created or where else relevant.
  • I've replaced magic method usage on DbService classes with the getInstance() static method.
  • I've written any documentation for new features or where else relevant in the docs repo.

Description

Convert the existing Insights module to support bootstrap5

Changelog

Added display_overlay property. Enables the form to be opened with or without “data_show_overlay”
Set using the form->open() method

system/classes/html/form.php

Additional parameter to enable the displaying of the “data_show_overlay” or not - default value is true
Modify $sl_class to "form-select" in mutlicolform when $type = ‘select’

system/classes/HtmlBootstrap5.php

system/templates/base/package-lock.json

Modified to use the bootstrap5 date picker
system/modules/admin/models/AuditInsight.php
system/modules/task/models/MyTaskTimeInsight.php

Modified to call HtmlBootstrap5 objects
system/modules/insights/actions/index.php
system/modules/insights/actions/viewInsight.php
system/modules/insights/actions/runInsight.php
system/modules/insights/templates/runInsight.tpl.php

Call to HtmlBootstrap5 objects, including multicoloured form call with dataOverlay parameter set to false
system/modules/insights/actions/export/bindpdf.php

Removed as no template file required by bindpdf.php
system/modules/insights/templates/export/bindpdf.tpl.php

refs:
issues:

Other Information

Two branches depend upon this branch:
crm feature/InsightsReportingBootstrap5
bridge_cmfive_module feature/InsightsReportingBootstrap5

Docs pull request:

@DerekCrannaford
Copy link
Contributor

This is a feature, but PR is like a 'fix'?
Ie: bootstrap insights are trying to fast-track straight into master, without merge into dev first as 'RC'?
(I can sympathise if trying to formalise current project work to release from master forces you into this)
But it also means we have to remember to bump this back into dev independently, to avoid master<-->dev risking creep again.

@2piJareem 2piJareem changed the base branch from master to develop June 29, 2023 23:39
@2piJareem
Copy link
Contributor Author

Changed PR to merge with develop

@chris-bateman chris-bateman mentioned this pull request Jul 30, 2024
32 tasks
@adam-buckley
Copy link
Contributor

I just realised this code is now redundant and/or not used anywhere - closing

@adam-buckley adam-buckley deleted the feature/InsightsReportingBootstrap5 branch August 1, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants