Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send json content type when sending json #307

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

MaddyUnderStars
Copy link
Contributor

Fixes invalid token responses getting html content type, etc

Checklist

  • I'm using the correct PHP Version (8.1 for current, 7.4 for legacy).

Description

Send application/json content type when sending json responses using ApiOutputService->apiReturnJsonResponse regardless of status code.
Fixes invalid token responses getting sent text/html content type

Fixes invalid token responses getting html content type, etc
Copy link

@DaltJM DaltJM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaddyUnderStars MaddyUnderStars merged commit 4a98a87 into develop Jun 4, 2024
9 checks passed
@MaddyUnderStars MaddyUnderStars deleted the fix/bad_token_response_type branch June 4, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants