Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force logout if deleting own user #308

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Force logout if deleting own user #308

merged 2 commits into from
Jun 4, 2024

Conversation

MaddyUnderStars
Copy link
Contributor

Checklist

  • I'm using the correct PHP Version (8.1 for current, 7.4 for legacy).
  • I've added comments to any new methods I've created or where else relevant.

Description

Closes #277.

Still a discussion to be had for whether or not admins should be able to delete the last admin account.

DaltJM
DaltJM approved these changes Jun 4, 2024
View reviewed changes
Copy link

@DaltJM DaltJM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaddyUnderStars MaddyUnderStars merged commit 66cd8e6 into develop Jun 4, 2024
9 checks passed
@MaddyUnderStars MaddyUnderStars deleted the feat/logout_on_delete branch June 4, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaltJM DaltJM DaltJM approved these changes

@dragonflyfree dragonflyfree Awaiting requested review from dragonflyfree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaddyUnderStars @DaltJM