Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change to mount instead of install #378

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fix: Change to mount instead of install #378

merged 3 commits into from
Sep 26, 2024

Conversation

mattbell87
Copy link
Member

Checklist

  • I'm using the correct PHP Version (8.1 for current, 7.4 for legacy).
  • I've added comments to any new methods I've created or where else relevant.
  • I've replaced magic method usage on DbService classes with the getInstance() static method.
  • I've written any documentation for new features or where else relevant in the docs repo.

Description

Changelog

refs:
issues:

Other Information

Docs pull request:

@mattbell87 mattbell87 changed the title Change to mount instead of install Fix: Change to mount instead of install Sep 26, 2024
@mattbell87 mattbell87 marked this pull request as ready for review September 26, 2024 03:21
@mattbell87 mattbell87 merged commit fa14a49 into main Sep 26, 2024
9 checks passed
@mattbell87 mattbell87 deleted the fix/ciCoreMount branch September 26, 2024 03:29
iceaxeliehne added a commit that referenced this pull request Sep 26, 2024
* Fix/timezone fix  (#366)

* Fix timezone issue once and for all

* improved timezone testing

* Update ci.yml

set locale so that dates are formatted correctly when running tests

* Update ci.yml

trying another way

* Update ci.yml

trying for timelog tests

* Try global env

---------

Co-authored-by: Matt Bell <[email protected]>

* Fix: CI for day/month date tests (#377)

* Logging of testrun context, with explicit locale setting

* Stepwise check for yml typos

* Fix yml indent

---------

Co-authored-by: Derek Crannaford <[email protected]>

* Fix: Change to mount instead of install (#378)

* Change to mount instead of install

* Improve source code details section

* Less output from GIT log

---------

Co-authored-by: Adam Buckley <[email protected]>
Co-authored-by: Matt Bell <[email protected]>
Co-authored-by: DerekCrannaford <[email protected]>
Co-authored-by: Derek Crannaford <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants