fix(strak-count): Handling when completedDays is null

392-f24 · Nov 8, 2024 · 84ad619 · 84ad619
1 parent 440dadf
commit 84ad619
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/hooks/useGoalsUpdater.test.js b/src/hooks/useGoalsUpdater.test.js
@@ -105,9 +105,6 @@ describe('useGoalsUpdater', () => {
       ],
     })
 
-    // should be empty Array
-    expect(user.streak).toEqual([])
-
     await goalsUpdater.toggleTaskCompletion(
       goalIndex,
       microGoalIndex,
@@ -118,8 +115,8 @@ describe('useGoalsUpdater', () => {
       user.goals[goalIndex].microgoals[microGoalIndex].tasks[taskIndex]
     expect(task.completed).toBe(true)
 
-    // check streak is not empty
-    expect(user.streak).not.toEqual([])
+    // Check user.streak.completedDays length is 1
+    expect(Object.keys(user.streak.completedDays)).toHaveLength(1)
   })
 
   it('should delete a specified task', async () => {

diff --git a/src/utils/streakUtils.js b/src/utils/streakUtils.js
@@ -28,12 +28,16 @@ export const getChicagoDate = () => {
  */
 export const updateStreakDays = (streak, countChange) => {
   const currentDate = getChicagoDate()
+  const completedDays = streak.completedDays || {}
 
   // Get the current count for the current date or initialize it to 0
-  const currentCount = streak.completedDays[currentDate] || 0
+  const currentCount = completedDays[currentDate] || 0
 
   // Update the count for the current date
-  streak.completedDays[currentDate] = Math.max(0, currentCount + countChange)
+  streak.completedDays = {
+    ...completedDays,
+    [currentDate]: Math.max(0, currentCount + countChange),
+  }
 
   return streak
 }