Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(due): implement due date for tasks #24

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Conversation

chipanyanwu
Copy link
Contributor

@chipanyanwu chipanyanwu commented Nov 7, 2024

  • Implement with @mui/x-date-pickers/DateTimePicker.

    • Can select a date with time. able to select time back before today.
    • Will turn red background if past and incomplete.
  • Add new field due for task, default null.

Feature Preview

image

Copy link

github-actions bot commented Nov 7, 2024

🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-24-ciexysga.web.app

🧪 Test Results

Tests Passed: All tests passed successfully!


🎨 Prettier Format Check

Prettier: No formatting issues found!

🎨 Lint Check

Lint: No linting issues found!

1 similar comment
Copy link

github-actions bot commented Nov 7, 2024

🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-24-ciexysga.web.app

🧪 Test Results

Tests Passed: All tests passed successfully!


🎨 Prettier Format Check

Prettier: No formatting issues found!

🎨 Lint Check

Lint: No linting issues found!

@ZL-Asica
Copy link
Member

ZL-Asica commented Nov 7, 2024

I will take a look tmr morning.

@ZL-Asica
Copy link
Member

ZL-Asica commented Nov 7, 2024

Just checked the preview. Since this is a mobile app, we should keep the add button for users to click instead of using enter on keyboard only.

screen

Copy link

github-actions bot commented Nov 7, 2024

🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-24-ciexysga.web.app

🧪 Test Results

Tests Passed: All tests passed successfully!


🎨 Prettier Format Check

Prettier: No formatting issues found!

🎨 Lint Check

Lint: No linting issues found!

Copy link

github-actions bot commented Nov 7, 2024

🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-24-ciexysga.web.app

🧪 Test Results

Tests Passed: All tests passed successfully!


🎨 Prettier Format Check

Prettier: No formatting issues found!

🎨 Lint Check

Lint: No linting issues found!

@ZL-Asica ZL-Asica force-pushed the canyanwu/item-due-date branch from c35e0c3 to 97765ab Compare November 7, 2024 15:50
Copy link

github-actions bot commented Nov 7, 2024

🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-24-ciexysga.web.app

🧪 Test Results

Tests Passed: All tests passed successfully!


🎨 Prettier Format Check

Prettier: No formatting issues found!

🎨 Lint Check

Lint: No linting issues found!

- Move DateTimePickers to Home folder.
- Revert theme.js since is same as default values.
- Refactor DateTimePickers to improve consistency.
- Simplify logic in Task, MicroGoal and AddItem components.
@github-actions github-actions bot added size/M and removed size/L labels Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-24-ciexysga.web.app

🧪 Test Results

Tests Passed: All tests passed successfully!


🎨 Prettier Format Check

Prettier: No formatting issues found!

🎨 Lint Check

Lint: No linting issues found!

Copy link

github-actions bot commented Nov 7, 2024

🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-24-ciexysga.web.app

🧪 Test Results

Tests Passed: All tests passed successfully!


🎨 Prettier Format Check

Prettier: No formatting issues found!

🎨 Lint Check

Lint: No linting issues found!

@ZL-Asica ZL-Asica enabled auto-merge (squash) November 7, 2024 17:50
@ZL-Asica ZL-Asica changed the title feat(due date): implement due date for tasks feat(due): implement due date for tasks Nov 7, 2024
@ZL-Asica ZL-Asica added enhancement New feature or request and removed utils hooks pages assets labels Nov 7, 2024
@ZL-Asica ZL-Asica disabled auto-merge November 7, 2024 17:53
@ZL-Asica ZL-Asica merged commit 5b90ff4 into main Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants