Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goalDetails): Goals list redirects to goalDetails pages #26

Merged
merged 2 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/App.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Footer from '@/components/common/Footer'
import Header from '@/components/common/Header'
import LoadingCircle from '@/components/common/LoadingCircle'
import { UserProvider, useUser } from '@/contexts/UserContext'
import GoalDetails from '@/pages/GoalDetails'
import Home from '@/pages/Home'
import Streak from '@/pages/Streak'
import { theme } from '@/utils/theme'
Expand Down Expand Up @@ -49,6 +50,10 @@ const App = () => {
path='/streak'
element={<ProtectedRoute element={<Streak />} />}
/>
<Route
path='/goals/:macroGoalIndex'
element={<GoalDetails />}
/>
</Routes>
</div>

Expand Down
51 changes: 13 additions & 38 deletions src/components/Home/MacroGoal.jsx
Original file line number Diff line number Diff line change
@@ -1,56 +1,31 @@
import AddItem from '@/components/Home/AddItem'
import DeleteItem from '@/components/Home/DeleteItem'
import MicroGoal from '@/components/Home/MicroGoal'
import ProgressIndicator from '@/components/Home/ProgressIndicator'
import useGoalsUpdater from '@/hooks/useGoalsUpdater'
import { calculateProgress } from '@/utils/calculateProgress'
import { ExpandLess, ExpandMore } from '@mui/icons-material'
import {
Box,
Collapse,
Divider,
IconButton,
List,
Paper,
Typography,
} from '@mui/material'
import { Box, Paper, Typography } from '@mui/material'
import { useNavigate } from 'react-router-dom'

const MacroGoal = ({ macroGoal, macroGoalIndex }) => {
const { addMicrogoal, toggleGoalExpansion } = useGoalsUpdater()
const progress = calculateProgress(macroGoal.microgoals)
const navigate = useNavigate()

const handleNavigateToMicroGoals = () => {
navigate(`/goals/${macroGoalIndex}`)
}

return (
<Paper elevation={2} sx={{ p: 2, mb: 3, borderRadius: 2 }}>
<Box display='flex' alignItems='center'>
<Box
display='flex'
alignItems='center'
onClick={handleNavigateToMicroGoals}
sx={{ cursor: 'pointer' }}
>
<ProgressIndicator value={progress} size={40} thickness={3} />
<Typography variant='h6' sx={{ flexGrow: 1, ml: 2 }}>
{macroGoal.name}
</Typography>
<DeleteItem goalIndex={macroGoalIndex} />
<IconButton
onClick={() => toggleGoalExpansion(macroGoalIndex)}
size='small'
>
{macroGoal.expanded ? <ExpandLess /> : <ExpandMore />}
</IconButton>
</Box>
<Collapse in={macroGoal.expanded} timeout='auto' unmountOnExit>
<Divider sx={{ my: 1 }} />
<AddItem
label='New Microgoal'
onAdd={(microGoalName) => addMicrogoal(macroGoalIndex, microGoalName)}
/>
<List>
{macroGoal.microgoals.map((microGoal, microGoalIndex) => (
<MicroGoal
key={microGoalIndex}
microGoal={microGoal}
macroGoalIndex={macroGoalIndex}
microGoalIndex={microGoalIndex}
/>
))}
</List>
</Collapse>
</Paper>
)
}
Expand Down
13 changes: 6 additions & 7 deletions src/components/Home/MicroGoal.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,20 @@ import { ExpandLess, ExpandMore } from '@mui/icons-material'
import {
Box,
Collapse,
Divider,
IconButton,
List,
Paper,
Typography,
} from '@mui/material'

const MicroGoal = ({ microGoal, macroGoalIndex, microGoalIndex }) => {
const { addTask, toggleMicroGoalExpansion, toggleTaskCompletion } =
useGoalsUpdater()
const { addTask, toggleExpansion, toggleTaskCompletion } = useGoalsUpdater()
const progress = calculateProgress([microGoal])

return (
<Paper
elevation={1}
elevation={5}
sx={{ p: 1, mb: 2, bgcolor: 'background.default', borderRadius: 1 }}
>
<Box display='flex' alignItems='center'>
Expand All @@ -34,16 +34,15 @@ const MicroGoal = ({ microGoal, macroGoalIndex, microGoalIndex }) => {
microGoalIndex={microGoalIndex}
/>
<IconButton
onClick={() =>
toggleMicroGoalExpansion(macroGoalIndex, microGoalIndex)
}
onClick={() => toggleExpansion(macroGoalIndex, microGoalIndex)}
size='small'
>
{microGoal.expanded ? <ExpandLess /> : <ExpandMore />}
</IconButton>
</Box>
<Collapse in={microGoal.expanded} timeout='auto' unmountOnExit>
<List sx={{ pl: 2 }}>
<Divider sx={{ mt: 2 }} />
<List sx={{ pl: 2, pb: 3 }}>
{microGoal.tasks.map((task, taskIndex) => (
<Task
key={taskIndex}
Expand Down
26 changes: 1 addition & 25 deletions src/hooks/useGoalsUpdater.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ describe('useGoalsUpdater', () => {
expect(user.goals).toContainEqual({
name: goalName,
category,
expanded: false,
microgoals: [],
})

Expand Down Expand Up @@ -129,28 +128,6 @@ describe('useGoalsUpdater', () => {
)
})

it('should toggle goal expansion', async () => {
const goalIndex = 0

// Add initial goal to user data
user.goals.push({
name: 'Goal 1',
category: '#000000',
expanded: false,
microgoals: [],
})

await goalsUpdater.toggleGoalExpansion(goalIndex)

expect(user.goals[goalIndex].expanded).toBe(true)

expect(updateProfile).toHaveBeenCalledWith(
expect.objectContaining({
goals: user.goals,
})
)
})

it('should toggle microgoal expansion', async () => {
const goalIndex = 0
const microGoalIndex = 0
Expand All @@ -159,11 +136,10 @@ describe('useGoalsUpdater', () => {
user.goals.push({
name: 'Goal 1',
category: '#000000',
expanded: false,
microgoals: [{ name: 'MicroGoal 1', expanded: false, tasks: [] }],
})

await goalsUpdater.toggleMicroGoalExpansion(goalIndex, microGoalIndex)
await goalsUpdater.toggleExpansion(goalIndex, microGoalIndex)

expect(user.goals[goalIndex].microgoals[microGoalIndex].expanded).toBe(true)

Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useGoalsUpdater/addOperations.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { updateGoalsAndStreak } from './updateHelpers'
export const addGoal = async (userContext, goalName, category) => {
const updatedGoals = [
...userContext.user.goals,
{ name: goalName, category, expanded: false, microgoals: [] },
{ name: goalName, category, microgoals: [] },
]
await updateGoalsAndStreak(
userContext,
Expand Down
9 changes: 1 addition & 8 deletions src/hooks/useGoalsUpdater/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,20 +55,13 @@ const useGoalsUpdater = () => {
toggleTaskCompletion: (goalIndex, microGoalIndex, taskIndex) =>
toggleTaskCompletion(userContext, goalIndex, microGoalIndex, taskIndex),

/**
* Toggles the expansion status of a specified goal.
* @param {number} goalIndex - Index of the goal.
* @returns {Promise<void>}
*/
toggleGoalExpansion: (goalIndex) => toggleExpansion(userContext, goalIndex),

/**
* Toggles the expansion status of a specified microgoal.
* @param {number} goalIndex - Index of the goal.
* @param {number} microGoalIndex - Index of the microgoal.
* @returns {Promise<void>}
*/
toggleMicroGoalExpansion: (goalIndex, microGoalIndex) =>
toggleExpansion: (goalIndex, microGoalIndex) =>
toggleExpansion(userContext, goalIndex, microGoalIndex),
}
}
Expand Down
7 changes: 2 additions & 5 deletions src/hooks/useGoalsUpdater/toggleOperations.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,10 @@ export const toggleTaskCompletion = async (
export const toggleExpansion = async (
userContext,
goalIndex,
microGoalIndex = undefined
microGoalIndex
) => {
const updatedGoals = [...userContext.user.goals]
const target =
microGoalIndex !== undefined
? updatedGoals[goalIndex].microgoals[microGoalIndex]
: updatedGoals[goalIndex]
const target = updatedGoals[goalIndex].microgoals[microGoalIndex]
target.expanded = !target.expanded
await updateGoalsAndStreak(
userContext,
Expand Down
57 changes: 57 additions & 0 deletions src/pages/GoalDetails.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
import AddItem from '@/components/Home/AddItem'
import MicroGoal from '@/components/Home/MicroGoal'
import ProgressIndicator from '@/components/Home/ProgressIndicator'
import { useUser } from '@/contexts/UserContext'
import useGoalsUpdater from '@/hooks/useGoalsUpdater'
import { calculateProgress } from '@/utils/calculateProgress'
import { Box, List, Paper, Typography } from '@mui/material'
import { useParams } from 'react-router-dom'

const GoalDetails = () => {
const { macroGoalIndex } = useParams()
const { user } = useUser()
const { addMicrogoal } = useGoalsUpdater()

const macroGoal = user.goals[macroGoalIndex]
const progress = calculateProgress(macroGoal.microgoals)

return (
<Box sx={{ p: 4 }}>
<Paper
elevation={3}
sx={{
p: 2,
mb: 3,
borderRadius: 2,
border: '2px solid',
borderColor: macroGoal.category ? macroGoal.category : '#000',
}}
>
<Box display='flex' alignItems='center'>
<ProgressIndicator value={progress} size={50} thickness={4} />
<Typography variant='h5' sx={{ ml: 2 }}>
{macroGoal.name}
</Typography>
</Box>
</Paper>

<AddItem
label='New MicroGoal'
onAdd={(microGoalName) => addMicrogoal(macroGoalIndex, microGoalName)}
/>

<List sx={{ mt: 3 }}>
{macroGoal.microgoals.map((microGoal, microGoalIndex) => (
<MicroGoal
key={microGoalIndex}
microGoal={microGoal}
macroGoalIndex={macroGoalIndex}
microGoalIndex={microGoalIndex}
/>
))}
</List>
</Box>
)
}

export default GoalDetails
2 changes: 1 addition & 1 deletion src/pages/Home.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const Home = () => {
const { addGoal } = useGoalsUpdater()

return (
<Box sx={{ maxWidth: 800, margin: 'auto', padding: 2 }}>
<Box sx={{ maxWidth: 800, margin: 'auto', padding: 3 }}>
<AddItem label='New Goal' onAdd={addGoal} />

{/* Render existing goals */}
Expand Down
Loading