Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/feat: app structure and add confirmation dialog for sign-out #8

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

ZL-Asica
Copy link
Member

  • Moved Footer out of App.jsx and utilized React Router to manage the current page state.
  • Added ConfirmSignOutDialog to prevent accidental sign-outs, improving user interaction.
  • Adjusted Header position to be outside the content div avoid wrong css styling.
  • Separated Streak component from App.jsx for easier future development.

Copy link

🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-8-u153eeuo.web.app

@ZL-Asica ZL-Asica disabled auto-merge October 28, 2024 05:52
@ZL-Asica ZL-Asica merged commit 45cf12a into main Oct 28, 2024
4 checks passed
@ZL-Asica ZL-Asica deleted the refactor/extract-footer branch October 28, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant