fix: validation for courses as mandatory in profile. (#13)

Set courseList in hook and output as errors.courseList to component for validation.
392-f24 · Oct 18, 2024 · ef7cc9d · ef7cc9d
1 parent 87b8d32
commit ef7cc9d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/components/Profile/EditProfile.jsx b/src/components/Profile/EditProfile.jsx
@@ -112,8 +112,8 @@ const EditProfile = () => {
               <TextField
                 {...params}
                 label="Courses"
-                error={!!errors.courses}
-                helperText={errors.courses && 'Please select your course(s)'}
+                error={errors.coursesList}
+                helperText={errors.coursesList && 'Please select your course(s)'}
                 margin="normal"
                 fullWidth
               />
@@ -138,8 +138,8 @@ const EditProfile = () => {
           {/* Location Preference */}
           <FormLabel component="legend">Location Preference</FormLabel>
           <FormGroup row sx={{ mb: 2 }}>
-            {renderCheckbox('In Person', 'inPerson', !!formData.inPerson, handleInputChange)}
-            {renderCheckbox('Online', 'online', !!formData.online, handleInputChange)}
+            {renderCheckbox('In Person', 'inPerson', formData.inPerson, handleInputChange)}
+            {renderCheckbox('Online', 'online', formData.online, handleInputChange)}
           </FormGroup>
 
           <Button variant="contained" color="primary" type="submit" disabled={!isFormValid}>

diff --git a/src/hooks/useEditProfileForm.js b/src/hooks/useEditProfileForm.js
@@ -40,7 +40,7 @@ const useEditProfileForm = (user) => {
             });
             setSelectedMajors(data.major ? data.major.split(',') : []);
             setSelectedCourses(data.listOfCourses || []);
-            setFirstTimeUser(Boolean(data.major && data.year));
+            setFirstTimeUser(!!(data.major && data.year));
           }
         } catch (error) {
           console.error('Error fetching profile, majors, and courses:', error);
@@ -79,7 +79,7 @@ const useEditProfileForm = (user) => {
       email: !/^\S+@\S+\.\S+$/.test(formData.email),
       phoneNumber: formData.phoneNumber.replace(/\D/g, '').length !== 10,
       major: selectedMajors.length === 0,
-      listClasses: selectedCourses.length === 0,
+      coursesList: selectedCourses.length === 0,
       year: !formData.year,
     };
     setErrors(newErrors);