Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

fix camera tiles #410

Merged
merged 7 commits into from
Mar 29, 2024
Merged

fix camera tiles #410

merged 7 commits into from
Mar 29, 2024

Conversation

Algorush
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Mar 16, 2024

Deploy Preview for 3dstreet-editor-builds ready!

Name Link
🔨 Latest commit d4fe1f3
🔍 Latest deploy log https://app.netlify.com/sites/3dstreet-editor-builds/deploys/660708c663a8cc00080e23bf
😎 Deploy Preview https://deploy-preview-410--3dstreet-editor-builds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

add versioning to mapbox and 3d tiles dependencies
- NOTE: had to move reference layer down because of nytimes/aframe-loader-3dtiles-component#45
@kfarr
Copy link
Contributor

kfarr commented Mar 29, 2024

@Algorush
issues remaining:

@Algorush
Copy link
Collaborator Author

Algorush commented Mar 29, 2024

  • 3d tiles do not update with inspector camera (in editor mode)

camera in Editor mode should work after applying also this PR from the Editor repo:
#410

@kfarr
Copy link
Contributor

kfarr commented Mar 29, 2024

@Algorush yes I am testing on this PR #410. Here is a video of the current behavior. The component appears to not be paused (good!) but the tiles do not update based on the change of editor camera pose:

410-feedback720p.mov

@kfarr
Copy link
Contributor

kfarr commented Mar 29, 2024

Also let's ignore the saving issue, it's a blessing in disguise that saving does not work

@Algorush
Copy link
Collaborator Author

Algorush commented Mar 29, 2024

Sorry, I linked in this PR instead of PR in aframe-loader-3dtiles: 3DStreet/aframe-loader-3dtiles-component#3
Camera should work with new dist of aframe 3dtiles component from this PR, have you tried with it?

@kfarr
Copy link
Contributor

kfarr commented Mar 29, 2024

Ok this all works as expected now, thanks. I did have to copy this to the local repo for now. Later we could just publish this to npm and include as a dependency? I will remove from index.html and test adding via console and maybe even database

restore index.html to previous state
@kfarr kfarr merged commit f69542d into master Mar 29, 2024
4 checks passed
@kfarr kfarr deleted the fix-camera-tiles branch March 29, 2024 18:32
@Algorush
Copy link
Collaborator Author

Algorush commented Mar 29, 2024

I haven't added orthographic camera support yet. Almost finished it, I wanted to ask you to review it.
And also later I will add a limitation of the tiles loading area.
I will do it in 3dstreet/aframe-loader-3dtiles-component

Later we could just publish this to npm and include as a dependency?

I don't know if we need to add camera support in the nytimes/aframe-loader-3dtiles-component yet, because it depends on this PR 410. But updating camera tiles won't work in the aframe-inspector. Later I intend to make this work for aframe-inpector as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants