This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
billing #422
Open
rostyslavvnahornyi
wants to merge
7
commits into
master
Choose a base branch
from
feature/issue-407/billing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
billing #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for 3dstreet-editor-builds failed.
|
thanks @rostyslavvnahornyi confirming receipt and will begin review |
Some notes on first review:
Next step for this:
Therefore requests of Rosty:
|
remove husky check
trigger recheck
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello @kfarr , there is first version of billing.
this branch needs to be tested locally only and if everything will be fine, i propose to call with you to set up all permissions, accesses, for stripe, google map api, google console, firebase functions to push branch into 'master'.
if there will be problems - let me know, i fix as soon as possible. And i want to talk about design because there are some disavtanges of billing that i met.
Test card: 4242 4242 4242 4242 |||| 12/34 |||| 567.