Skip to content

Commit

Permalink
emit newScene event when all the entities are created
Browse files Browse the repository at this point in the history
  • Loading branch information
vincentfretin committed Sep 2, 2024
1 parent afb7aa2 commit f1ff99d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
1 change: 1 addition & 0 deletions src/editor/components/scenegraph/Toolbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ export default class Toolbar extends Component {
newHandler = () => {
AFRAME.INSPECTOR.selectEntity(null);
STREET.utils.newScene();
AFRAME.scenes[0].emit('newScene');
};

cloudSaveHandler = async ({ doSaveAs = false }) => {
Expand Down
8 changes: 2 additions & 6 deletions src/editor/lib/toolbar.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import Events from './Events';

export function inputStreetmix() {
const streetmixURL = prompt(
'Please enter a Streetmix URL',
Expand All @@ -21,8 +19,7 @@ export function inputStreetmix() {
streetmixURL
);

// update sceneGraph
Events.emit('updatescenegraph');
AFRAME.scenes[0].emit('newScene');
}

export function createElementsForScenesFromJSON(streetData) {
Expand All @@ -38,15 +35,14 @@ export function createElementsForScenesFromJSON(streetData) {
}

STREET.utils.createEntities(streetData, streetContainerEl);
AFRAME.scenes[0].emit('newScene');
}

export function fileJSON(event) {
let reader = new FileReader();

reader.onload = function () {
STREET.utils.createElementsFromJSON(reader.result);
// update sceneGraph
Events.emit('updatescenegraph');
};

reader.readAsText(event.target.files[0]);
Expand Down
2 changes: 2 additions & 0 deletions src/json-utils_1.1.js
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,7 @@ function inputStreetmix() {
'streetmixStreetURL',
streetmixURL
);
AFRAME.scenes[0].emit('newScene');
}

STREET.utils.inputStreetmix = inputStreetmix;
Expand Down Expand Up @@ -677,6 +678,7 @@ function createElementsFromJSON(streetJSON) {

createEntities(streetObject.data, streetContainerEl);
STREET.notify.successMessage('Scene loaded from JSON');
AFRAME.scenes[0].emit('newScene');
}

STREET.utils.createElementsFromJSON = createElementsFromJSON;
Expand Down
2 changes: 0 additions & 2 deletions src/street-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ function newScene(
window.location.hash = '';
});
}

AFRAME.scenes[0].emit('newScene');
}

STREET.utils.newScene = newScene;
Expand Down

0 comments on commit f1ff99d

Please sign in to comment.