update camera aspect ratio in Plan View and Cross Section

[Algorush]

[vincentfretin]

See my comments 3DStreet/3dstreet-editor#185 (comment)

[Algorush]

See my comments 3DStreet/3dstreet-editor#185 (comment)

Thanks, I read the comments but didn't look in detail yet. Yes, the parameters of the Ortho camera are different from the Perspective camera. Perhaps this is causing the problem. I studied ortho and perspective cameras while working with 3dtiles-loader, I'll try to fix this

[vincentfretin]

Good luck. I spend about 2 hours trying without success.

[vincentfretin]

Oh I see that EditorControls is also messing around the left bottom right top property of the ortho camera

3dstreet/src/editor/lib/EditorControls.js

Lines 120 to 134 in 5d6bacc

	if (this.isOrthographic) {
	// Change FOV for ortho.
	let factor = 1;
	if (delta.x + delta.y + delta.z < 0) {
	factor = -1;
	}
	delta = distance * scope.zoomSpeed * factor;
	object.left -= delta * ratio;
	object.bottom -= delta;
	object.right += delta * ratio;
	object.top += delta;
	if (object.left >= -0.0001) {
	return;
	}
	object.updateProjectionMatrix();

I missed that code when I tried to fix the issue.

[vincentfretin]

3dstreet/src/editor/lib/viewport.js

Line 212 in 5d6bacc

controls.setAspectRatio(sceneEl.canvas.width / sceneEl.canvas.height);

probably just need to be executed on resize

[Algorush]

I made it work. I'll add a PR later. in window resize I first calculate FrustumSize, then add parameters for ortho camera. It works with Plan View in inspector, but not with Cross Section View:

        if (inspector.camera.isOrthographicCamera) {
          const frustumSize = inspector.camera.top - inspector.camera.bottom;
          inspector.camera.left = -frustumSize * aspect / 2;
          inspector.camera.right = frustumSize * aspect / 2;
          inspector.camera.top = frustumSize / 2;
          inspector.camera.bottom = -frustumSize / 2;
        }

so I need to do this work in Cross Section View also

[Algorush]

I fixed it with Cross Section View too.
I'll try to add this fix in aframe repo in resize event function here: https://github.com/aframevr/aframe/blob/66baa9c8128caf9199e8a773ca4d637a25947d06/src/core/scene/a-scene.js#L577

[Algorush]

Added PR here in 3DStreet. I was unable to clone the aframe repository due to an error during the download, perhaps a problem with my unstable connection in a rural area

[vincentfretin]

I'll make changes to your PR.
Also for reference in three.js editor:
https://github.com/mrdoob/three.js/blob/1845f6cd0525b5c73b9da33c40e198c360af29f1/editor/js/Viewport.js#L153-L179

[vincentfretin]

PR #694 fixes the issue.

[kfarr]

closed by #694