[bugfix] Update camera aspect ratio on window resize #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
commented
Jul 17, 2024
| @@ -118,5 +118,4 @@ function setOrthoCamera(camera, dir, ratio) { | |||
| camera.bottom = info.bottom || -10; | |||
| camera.position.copy(info.position); | |||
| camera.rotation.copy(info.rotation); | |||
| camera.updateProjectionMatrix(); | |||
There was a problem hiding this comment.
This is now done in the updateAspectRatio() call that is done on cameratoggle event.
| if (cameraHelper) cameraHelper.update(); | ||
| } | ||
|
|
||
| inspector.sceneEl.addEventListener('rendererresize', updateAspectRatio); |
There was a problem hiding this comment.
I'm using rendererresize that is emitted by the sceneEl.resize() function. sceneEl.resize() is called after switching the active camera when you close or open the inspector.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the aspect ratio of the editor camera worked only for the active perspective camera, it didn't work when when you were using orthographic camera, and also the case using ortho, resize and then switching back to perspective camera didn't work either. This PR fixes updating the camera aspect in all cases.
For more details on the issue, this was discussed in 3DStreet/3dstreet#635