Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new animated chars #461

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add new animated chars #461

wants to merge 6 commits into from

Conversation

Algorush
Copy link
Collaborator

Not done yet. I also need to make different speeds for different characters.
And there is one issue to fix. After switching the globalAnimation in the street component to true, the added characters stand with their arms outstretched to the sides in the Editor, but after switching to View everything is fine

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for 3dstreet-core-builds ready!

Name Link
🔨 Latest commit 2a56e70
🔍 Latest deploy log https://app.netlify.com/sites/3dstreet-core-builds/deploys/65abe3f52df78000084f4dd7
😎 Deploy Preview https://deploy-preview-461--3dstreet-core-builds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Algorush
Copy link
Collaborator Author

It looks like Node v12 doesn't support "nullish coalescing operator (??)". I'll change it

node v12 on server doesn't support (??) operator
@kfarr
Copy link
Collaborator

kfarr commented Feb 23, 2024

It looks like Node v12 doesn't support "nullish coalescing operator (??)". I'll change it

we can upgrade node, i think 12 is pretty old now right?

@kfarr
Copy link
Collaborator

kfarr commented Mar 1, 2024

@Algorush is this ready for testing?

@kfarr
Copy link
Collaborator

kfarr commented Mar 4, 2024

a few questions @Algorush

  • so there is no more "people-rigged" category any more? now it is just "people" category that includes "achar..." mixin IDs.
  • how will this affect scenes with the old character mixin ID saved? How do support these legacy scenes?
  • what are the "default categories" of objects that are loaded now? all of them? it was hard for me to tell in assets.js.
  • what is the # of MB loading a scene before this change and # of MB to load a scene after this change? In other words is it more or less bytes transferred?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants