Load from url encoded json #500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for 3dstreet-core-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kfarr
reviewed
Mar 19, 2024
| @@ -67,14 +67,58 @@ AFRAME.registerComponent('streetmix-loader', { | |||
| streetmixStreetURL: { type: 'string' }, | |||
| streetmixAPIURL: { type: 'string' }, | |||
| showBuildings: { default: true }, | |||
| name: { default: '' } | |||
| name: { default: '' }, | |||
| streetmixJSON: { type: 'string', default: '' } | |||
There was a problem hiding this comment.
I think this could be set directly on the street component instead of streetmix-loader component? there is already a property called JSON on the street component?
|
Thanks please see: https://github.com/3DStreet/3dstreet/pull/500/files#r1529712137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to load from url encoded streetmix json you need:
StreetmixAPIURLparameter in thestreetmix-loadercomponent of the #default-street element. String can be encoded through encodeURIComponent func in console or here for example: https://www.urlencoder.org/http://localhost:7001/#streetmix-json:orhttp://localhost:7001/#3dstreet-json:for 3dstreet data