Normalize mixins #699
Open
Normalize mixins #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove `markings` mixin merge its same properties to all of the striping mixins it is usually paired with also remove anisotropy
src/assets.js
Outdated
| <a-mixin id="hash-right" atlas-uvs="totalRows: 4; totalColumns: 8; column: 8; row: 2" scale="3 6 3"></a-mixin> | ||
| <a-mixin id="hash-chevron" atlas-uvs="totalRows: 4; totalColumns: 4; column: 4; row: 2" scale="3 3 3"></a-mixin> | ||
| <a-mixin id="stencils"></a-mixin> | ||
| <a-mixin shadow="cast: false" id="right" atlas-uvs="totalRows: 4; totalColumns: 4; column: 3; row: 2" scale="2 2 2" geometry="primitive: plane;" material="src: #stencils-atlas;alphaTest: 0;transparent:true;"></a-mixin> |
There was a problem hiding this comment.
You need geometry="primitive: plane; skipCache: true everywhere to be sure to create a separate geometry for each entity, otherwise all your entities are using the same geometry and the atlas-uvs component is changing the uvs of the shared geometry so replacing the image for all entities.
There was a problem hiding this comment.
@vincentfretin excellent, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.