Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intro video #786

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Add intro video #786

merged 2 commits into from
Aug 22, 2024

Conversation

rahulkgupta
Copy link
Collaborator

Screenshot 2024-08-22 at 1 42 36 PM

@rahulkgupta rahulkgupta marked this pull request as ready for review August 22, 2024 20:43
@rahulkgupta rahulkgupta requested a review from kfarr August 22, 2024 20:43
@kfarr kfarr merged commit a7dbaca into main Aug 22, 2024
1 check passed
@kfarr kfarr deleted the intro-video branch August 22, 2024 23:21
@vincentfretin
Copy link
Collaborator

3dstreet-editor.js went from 1,6M to 2,5M with the mux video player. We should probably look into lazy loading the modals again soon #557

@kfarr
Copy link
Collaborator

kfarr commented Aug 23, 2024

@vincentfretin agreed that would be a good thing. in addition, to lazy loading, we can reduce size with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants