Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo image change + toolbar button color change #907

Merged
merged 6 commits into from
Nov 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<!-- viewer ui start -->
<div class="viewer-header-wrapper">
<button class="viewer-logo-start-editor-button" onclick="startEditor()">
<img class="viewer-logo-img" alt="3DStreet Viewer" src="ui_assets/3DStreet-Viewer-Start-Editor.svg">
<img class="viewer-logo-img" alt="3DStreet Viewer" src="ui_assets/3D-St-stacked-128.png">
</button>
</div>

Expand Down
6 changes: 2 additions & 4 deletions src/editor/components/components/Logo/Logo.component.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import { EditorLogo, ViewerLogo } from './logos.jsx';

import { Button } from '../Button';
import PropTypes from 'prop-types';
import styles from './Logo.module.scss';
Expand All @@ -13,9 +11,9 @@ import styles from './Logo.module.scss';
const Logo = ({ onToggleEdit, isEditor }) => (
<div className={styles.wrapper}>
<div className={styles.logo} id="logoImg">
{isEditor ? <EditorLogo /> : <ViewerLogo />}
<img src="ui_assets/3D-St-stacked-128.png" alt="3DStreet Logo" />
</div>
<Button onClick={onToggleEdit} className={styles.btn}>
<Button onClick={onToggleEdit} className={styles.btn} variant="toolbtn">
{isEditor ? 'Enter Viewer mode' : 'Enter Editor mode'}
</Button>
</div>
Expand Down
14 changes: 8 additions & 6 deletions src/editor/components/components/Logo/Logo.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,17 @@
column-gap: 1.5rem;
}

.logo {
img {
width: 48px;
height: 48px;
object-fit: contain;
}
}
@media screen and (max-width: 1268px) {
.wrapper {
column-gap: 0rem;
flex-direction: column;
column-gap: 1.5rem;
row-gap: 12px;
left: 20px;
top: 24px;
.btn {
width: 100%;
}
}
}
31 changes: 0 additions & 31 deletions src/editor/components/components/Logo/logos.jsx

This file was deleted.

5 changes: 5 additions & 0 deletions src/editor/components/scenegraph/Toolbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ export default class Toolbar extends Component {
leadingIcon={<Edit24Icon />}
onClick={this.newHandler}
disabled={this.state.isSavingScene}
variant="toolbtn"
>
<div className="hideInLowResolution">New</div>
</Button>
Expand All @@ -319,6 +320,7 @@ export default class Toolbar extends Component {
leadingIcon={<Save24Icon />}
onClick={this.toggleSaveActionState.bind(this)}
disabled={this.state.isSavingScene}
variant="toolbtn"
>
<div className="hideInLowResolution">Save</div>
</Button>
Expand Down Expand Up @@ -348,6 +350,7 @@ export default class Toolbar extends Component {
leadingIcon={<Save24Icon />}
onClick={this.handleUnsignedSaveClick}
disabled={this.state.isSavingScene}
variant="toolbtn"
>
<div className="hideInLowResolution">Save</div>
</Button>
Expand All @@ -356,6 +359,7 @@ export default class Toolbar extends Component {
<Button
leadingIcon={<Upload24Icon />}
onClick={() => Events.emit('openscenesmodal')}
variant="toolbtn"
>
<div className="hideInLowResolution">Open</div>
</Button>
Expand All @@ -366,6 +370,7 @@ export default class Toolbar extends Component {
this.makeScreenshot();
Events.emit('openscreenshotmodal');
}}
variant="toolbtn"
>
<div className="hideInLowResolution">Share</div>
</Button>
Expand Down
5 changes: 0 additions & 5 deletions src/editor/viewer-styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ body {
align-items: center;
}

.viewer-logo-img {
height: 43px;
width: 370px;
}

.viewer-logo-start-editor-button {
border: none;
background: none;
Expand Down
5 changes: 0 additions & 5 deletions src/viewer-styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,6 @@ body {
align-items: center;
}

.viewer-logo-img {
height: 43px;
width: 370px;
}

.viewer-logo-start-editor-button {
border: none;
background: none;
Expand Down
Binary file added ui_assets/3D-St-stacked-128.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.