Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLT Hebrew subtitles update#2 #121

Merged
merged 1 commit into from
Feb 19, 2024
Merged

CLT Hebrew subtitles update#2 #121

merged 1 commit into from
Feb 19, 2024

Conversation

davidBar-On
Copy link
Contributor

Enhancing the previous enhancement to the CTL Hebrew subtitles, after viewing the video with the updated subtitles. It would really help if there will be a way to view the updated subtitles with the video before committing the PR.

Also, I noticed in one case that the English text used for the Hebrew translation was not the same as the English subtitles for the video. If it is possible to translate the text only after the English text is final, it would help for both the auto translation and the updates to the translation.

Enhancing the previous enhancement to the CTL Hebrew subtitles, after viewing the video with the updated subtitles.  It would really help if there will be a way to view the updated subtitles with the video before committing the PR.

Also, I noticed in one case that the English text used for the Hebrew translation was not the same as the English subtitles for the video.  If it is possible to translate the text only after the English text is final, it would help for both the auto translation and the updates to the translation.
@github-actions github-actions bot added the Hebrew label Feb 5, 2024
@3b1b
Copy link
Owner

3b1b commented Feb 19, 2024

Thanks for the contribution! Soon we'll have a better interface that lets you see the relevant portion of the video while editing a translation, I know it's certainly suboptimal as-is.

@3b1b 3b1b merged commit 34f43e9 into 3b1b:main Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants