Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE/GER] entire 2015 dir fixed #150

Merged
merged 20 commits into from
Feb 19, 2024
Merged

[DE/GER] entire 2015 dir fixed #150

merged 20 commits into from
Feb 19, 2024

Conversation

Dat-Pudding
Copy link
Contributor

There's a distinct lack of transcripts tho

Someone more educated in musical jargon should ideally re-check /2015/music-and-measure-theory

- fixed wonky translations
- deformalised phrasing
- converted to lingual default maskulinum

Still requires:
- someone more educated on musical jargon checking through
@github-actions github-actions bot added the German label Feb 7, 2024
]
},
{
"input": "By open interval, I just mean the continuous stretch of real numbers strictly greater than some number a, but strictly less than some other number b, where b is of course greater than My challenge to you involves covering all of the rational numbers between 0 and 1 with open intervals.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3b1b The english text looks incomplete.
where b is of course greater than ... than what? a?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, that is missing an "a"

@@ -677,7 +677,7 @@
{
"input": "You could imagine that for her, harmonious numbers are precisely those 1% covered by the intervals, provided that her tolerance for error goes down exponentially for more complicated rationals.",
"model": "nmt",
"translatedText": "Man könnte sich vorstellen, dass harmonische Zahlen für sie genau die 1 % sind, die von den Intervallen abgedeckt werden, vorausgesetzt, dass ihre Fehlertoleranz bei komplizierteren rationalen Zahlen exponentiell abnimmt.",
"translatedText": "Man könnte sich vorstellen, dass harmonische Zahlen für ihn genau die 1% sind, die von den Intervallen abgedeckt werden, vorausgesetzt, dass ihre Fehlertoleranz bei komplizierteren rationalen Zahlen exponentiell abnimmt.",
Copy link
Contributor

@zsawyer zsawyer Feb 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3b1b you probably deliberately choose to use female pronouns. Switching to German generic masculine is generally ok here but I would like to inquiry upon the original intent since english provides a similar construct but was not chosen.
Keep explicitly female pronouns or switch to generic masculine?

The current change would apply (generic) masculine.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no gender-neutral term, I'd err on the side of matching the original. But if that sounds strange or unnatural, or calls excessive attention to itself, then go for what sounds natural. Not speaking German, I find it hard to judge the implications.

Copy link
Contributor

@zsawyer zsawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full review conducted. Suggestions provided. Some I consider mandatory.
2 questions for 3b1b posted

Note: tone change from formal to informal as previously done and merged for shorts

@zsawyer
Copy link
Contributor

zsawyer commented Feb 11, 2024

Someone more educated in musical jargon should ideally re-check /2015/music-and-measure-theory

I am not musically proficient so the jargon could still use a review.

Copy link

@FuchsCrafter FuchsCrafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone who has a moderate understanding of music, the parts with the words regarding music seem fine to me.

Dat-Pudding and others added 15 commits February 11, 2024 21:54
@3b1b 3b1b merged commit 919ef61 into 3b1b:main Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants