-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DE/GER] entire 2015 dir fixed #150
Conversation
- fixed wonky translations - deformalised phrasing - converted to lingual default maskulinum Still requires: - someone more educated on musical jargon checking through
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
] | ||
}, | ||
{ | ||
"input": "By open interval, I just mean the continuous stretch of real numbers strictly greater than some number a, but strictly less than some other number b, where b is of course greater than My challenge to you involves covering all of the rational numbers between 0 and 1 with open intervals.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3b1b The english text looks incomplete.
where b is of course greater than ... than what? a?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, that is missing an "a"
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
@@ -677,7 +677,7 @@ | |||
{ | |||
"input": "You could imagine that for her, harmonious numbers are precisely those 1% covered by the intervals, provided that her tolerance for error goes down exponentially for more complicated rationals.", | |||
"model": "nmt", | |||
"translatedText": "Man könnte sich vorstellen, dass harmonische Zahlen für sie genau die 1 % sind, die von den Intervallen abgedeckt werden, vorausgesetzt, dass ihre Fehlertoleranz bei komplizierteren rationalen Zahlen exponentiell abnimmt.", | |||
"translatedText": "Man könnte sich vorstellen, dass harmonische Zahlen für ihn genau die 1% sind, die von den Intervallen abgedeckt werden, vorausgesetzt, dass ihre Fehlertoleranz bei komplizierteren rationalen Zahlen exponentiell abnimmt.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3b1b you probably deliberately choose to use female pronouns. Switching to German generic masculine is generally ok here but I would like to inquiry upon the original intent since english provides a similar construct but was not chosen.
Keep explicitly female pronouns or switch to generic masculine?
The current change would apply (generic) masculine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no gender-neutral term, I'd err on the side of matching the original. But if that sounds strange or unnatural, or calls excessive attention to itself, then go for what sounds natural. Not speaking German, I find it hard to judge the implications.
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
2015/music-and-measure-theory/german/sentence_translations.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full review conducted. Suggestions provided. Some I consider mandatory.
2 questions for 3b1b posted
Note: tone change from formal to informal as previously done and merged for shorts
I am not musically proficient so the jargon could still use a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone who has a moderate understanding of music, the parts with the words regarding music seem fine to me.
…Line:221 Co-authored-by: zsawyer <[email protected]>
…s.json Line:266 Co-authored-by: zsawyer <[email protected]>
…s.json Line:329 Co-authored-by: zsawyer <[email protected]>
…s.json Line:338 Co-authored-by: zsawyer <[email protected]>
…s.json Line:347 Co-authored-by: zsawyer <[email protected]>
…s.json Line:374 Co-authored-by: zsawyer <[email protected]>
…s.json Line:428 Co-authored-by: zsawyer <[email protected]>
…s.json Line:446 Co-authored-by: zsawyer <[email protected]>
…s.json Line:491 Co-authored-by: zsawyer <[email protected]>
…s.json Line:509 Co-authored-by: zsawyer <[email protected]>
…s.json Line:545 Co-authored-by: zsawyer <[email protected]>
…s.json Line:554 Co-authored-by: zsawyer <[email protected]>
…s.json Line:581 Co-authored-by: zsawyer <[email protected]>
…s.json Line:617 Co-authored-by: zsawyer <[email protected]>
…s.json Line:572 Co-authored-by: zsawyer <[email protected]>
…s.json Line:464 Co-authored-by: zsawyer <[email protected]>
…s.json Line:680 Co-authored-by: zsawyer <[email protected]>
There's a distinct lack of transcripts tho
Someone more educated in musical jargon should ideally re-check /2015/music-and-measure-theory