Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload button #367

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Add upload button #367

merged 6 commits into from
Mar 12, 2024

Conversation

vincerubinetti
Copy link
Collaborator

@vincerubinetti vincerubinetti commented Mar 11, 2024

@FaboBence Please test the upload feature in the Netlify preview link below.

  • move "insufficient file" error to top of create pr script, so the error is discovered early, before branch is created
  • re-run update.ts script to fill in more lesson full titles
  • fix bug where submitting empty files would throw error
  • add ability to upload previously downloaded zip
  • make more comprehensive pre-populated issue links
  • add "view raw json" button with link to line number
  • fix case sensitivity bug in homepage lesson name search

This was linked to issues Mar 11, 2024
@vincerubinetti vincerubinetti requested a review from 3b1b March 11, 2024 18:15
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for translate3b1b ready!

Name Link
🔨 Latest commit 881f223
🔍 Latest deploy log https://app.netlify.com/sites/translate3b1b/deploys/65f06cf9ab09ce0008f42776
😎 Deploy Preview https://deploy-preview-367--translate3b1b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FaboBence
Copy link
Contributor

I have tested the described functionality with main focus on the ZIP uploads. It's working well!

@3b1b
Copy link
Owner

3b1b commented Mar 12, 2024

It looks reasonable to me, and appears to work when I test it.

@3b1b
Copy link
Owner

3b1b commented Mar 12, 2024

Any objection if I merge?

@vincerubinetti
Copy link
Collaborator Author

Good to go

@3b1b 3b1b merged commit e84f7b3 into main Mar 12, 2024
2 checks passed
@3b1b 3b1b deleted the upload branch March 12, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTL Translations are Missing in the Tool Misc app UI enhancements
3 participants