Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentence_translations.json #77

Merged
merged 6 commits into from
Feb 19, 2024
Merged

Update sentence_translations.json #77

merged 6 commits into from
Feb 19, 2024

Conversation

cheskoxd
Copy link
Contributor

@cheskoxd cheskoxd commented Feb 4, 2024

-Fix broken sentences due to translation
-Changed some sentences to sound more native
-Swapped some words with their common synonym
-Fix channel name broken due to translation

Quick question,
Should we translate the name of the channel?

-Fix broken sentences due to translation 
-Changed some sentences to sound more native
-Swapped some words with their common synonym
-Fix channel name broken due to translation 

Quick question,
Should we translate the name of the channel?
-Changed some pronouns and verbs from singular to plural (since Grant is talking to a group of people)
@cheskoxd cheskoxd marked this pull request as ready for review February 4, 2024 17:31
@imlargo
Copy link
Contributor

imlargo commented Feb 4, 2024

¡Hola! También estoy trabajando en traducir al español. Con respecto a tu pregunta, creo que sería más adecuado dejar el nombre del canal en su idioma original, para mantener la idea y la "marca personal". Pero en todo caso, es simplemente mi opinión.


Hi! I'm also working on translating to Spanish. Regarding your question, I think it would be more appropriate to leave the channel name in its original language, in order to maintain the idea and the "personal brand". But in any case, that's just my opinion.

@cheskoxd
Copy link
Contributor Author

cheskoxd commented Feb 4, 2024

¡Hola! También estoy trabajando en traducir al español. Con respecto a tu pregunta, creo que sería más adecuado dejar el nombre del canal en su idioma original, para mantener la idea y la "marca personal". Pero en todo caso, es simplemente mi opinión.

Hi! I'm also working on translating to Spanish. Regarding your question, I think it would be more appropriate to leave the channel name in its original language, in order to maintain the idea and the "personal brand". But in any case, that's just my opinion.


Hey, pensaba lo mismo, ya que se escucha raro "tres azules y un marron", pero dijeron que usarian voces AI para las traducciones, y si es asi podria afectar a la hora de crear el audio en español, ya que 3blue1brown esta en ingles y el texto a audio solo puede hablar en un idioma.

Asi sonaria:
https://translate.google.com/?sl=es&tl=en&text=3blue1brown&op=translate


Hey, I also think that its better if we leave it in English, because in Spanish it sounds weird, but since they are going to use AI Voices to generate the audio, it might/will affect since the word 3blue1brown its in english and the text to speech can only talk in one language.

Here's how it will sound
https://translate.google.com/?sl=es&tl=en&text=3blue1brown&op=translate

Copy link
Contributor

@Yag000 Yag000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor tweaks.

@Yag000
Copy link
Contributor

Yag000 commented Feb 4, 2024

Regarding the translation of the channel name, I believe it's quite tricky in this case. Firstly, I think we should always keep '3blue1brown' as it is the actual name of the channel. However, the name was explicitly referenced as a weird name, and its meaning may not be clear to those who don't understand English. A potential solution could be to retain the English name but add a brief explanatory phrase, for instance: '...3blue1brown, tres azules y un marrón en español,...' where it was mention, l.562

cheskoxd and others added 2 commits February 4, 2024 16:31
Oh, I though it was `transformacion`, thanks!

Co-authored-by: Yago Iglesias <[email protected]>
@cheskoxd
Copy link
Contributor Author

cheskoxd commented Feb 4, 2024

Regarding the translation of the channel name, I believe it's quite tricky in this case. Firstly, I think we should always keep '3blue1brown' as it is the actual name of the channel. However, the name was explicitly referenced as a weird name, and its meaning may not be clear to those who don't understand English. A potential solution could be to retain the English name but add a brief explanatory phrase, for instance: '...3blue1brown, tres azules y un marrón en español,...' where it was mention, l.562

Got it, Ill update the file and submit it for review, thanks for this clarification!

Update to maintain the channel name and its translation in Spanish
Copy link
Contributor Author

@cheskoxd cheskoxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Fix broken sentences due to translation
-Changed some sentences to sound more native
-Swapped some words with their common synonym
-Fix channel name broken due to translation
-Update to maintain the channel name and its translation in Spanish

@Yag000
Copy link
Contributor

Yag000 commented Feb 4, 2024

-Update to maintain the channel name and its translation in Spanish

I think I misexplained myself. What I meant to say is that we should only keep 3blue1brown in the translation but add an explanation only the first time the name is mentioned, in line 562. If not, I believe it won't feel natural.

@3b1b
Copy link
Owner

3b1b commented Feb 5, 2024

I would leave the channel name as-is, and if the text-to-speech result does something very unnatural, we can address that on a further stage of the pipeline, e.g. programmatically replace it with a translation of "this channel" before running the TTS, or something like that.

Let me know when you feel this is okay to merge.

Removed the Spanish translation of the channel name, and left only the original name `3bluebrown`
@cheskoxd
Copy link
Contributor Author

cheskoxd commented Feb 5, 2024

I think I misexplained myself. What I meant to say is that we should only keep 3blue1brown in the translation but add an explanation only the first time the name is mentioned, in line 562. If not, I believe it won't feel natural.

Thanks for the clarification, I just added commit d908a9d to fix that, and now its ready to merge

I would leave the channel name as-is, and if the text-to-speech result does something very >unnatural, we can address that on a further stage of the pipeline, e.g. programmatically >replace it with a translation of "this channel" before running the TTS, or something like that.

You're right, using "this channel" sounds a lot more natural than using the translation for 3blue1brown.

Let me know when you feel this is okay to merge.

I just re-requested review to merge

@cheskoxd cheskoxd requested a review from Yag000 February 5, 2024 21:30
Copy link
Contributor

@Yag000 Yag000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)

@3b1b 3b1b merged commit e57002d into 3b1b:main Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants