-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[German] Reworked Wordle sentence_translations.json #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think many of the changes were improvements or at least didn't change things for the worse.
But there were a few fundamental questions (e.g. "du" vs "Sie") and a few recurring topics (e.g. "(Rate)versuch" instead of "Schätzung" or "Vermutung") (plus the expectable little glitches)
Corrected contributed errors, still needs some work
@@ -1541,7 +1610,7 @@ | |||
{ | |||
"input": "By the end of the simulation, the average score works out to be about 4.124.", | |||
"model": "nmt", | |||
"translatedText": "Am Ende der Simulation liegt die durchschnittliche Punktzahl bei etwa 4.124.", | |||
"translatedText": "Liegt die durchschnittliche Anzahl am Ende bei 4.124", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will we handle decimals?
"Vier-Punkt-Eins-Zwo-Vier" sounds more like some subsection of something rather than an actual decimal number like "vier-komma-eins-zwo-vier"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will we handle decimals? "Vier-Punkt-Eins-Zwo-Vier" sounds more like some subsection of something rather than an actual decimal number like "vier-komma-eins-zwo-vier"
Very good point that slipped my attention. It's probably best to convert to ",".
Rework of the Wordle-video.