-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable framerate fix for all branches #1189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a proper type as ShaderWrapper. This also includes some cleanup in hos Camera renders
…array sizes dont' match
…s a comment just because it's unclear what's best right now
I think you may have made a mistake, why did you make a pull request from the shaders branch to the master. If you are actually mistaken, please close this pull request. |
Yes, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manim generates variable framerate video instead of the constant value in the CONFIG
mp4fpsmod
tool can fix this. Unzip the attachment to manim folder and place this code to line502
ofscene_file_writer.py
right aftercombine_process.wait()
.Note: this tool does not work if you have opened the video file in another program.
mp4fpsmod.zip