avoid duplicate error log messages

3dcitydb · Feb 9, 2025 · 17feca1 · 17feca1
1 parent 0a7eaae
commit 17feca1
Show file tree

Hide file tree

Showing 25 changed files with 6 additions and 44 deletions.
diff --git a/citydb-cli/src/main/java/org/citydb/cli/ExecutionException.java b/citydb-cli/src/main/java/org/citydb/cli/ExecutionException.java
@@ -24,7 +24,6 @@
 public class ExecutionException extends Exception {
 
     public ExecutionException() {
-        super();
     }
 
     public ExecutionException(String message) {

diff --git a/citydb-cli/src/main/java/org/citydb/cli/util/CommandHelper.java b/citydb-cli/src/main/java/org/citydb/cli/util/CommandHelper.java
@@ -191,7 +191,12 @@ public synchronized void logException(String message, Throwable e) {
         Level level = LoggerManager.getInstance().logConsole().getLogLevel();
         if (level.isMoreSpecificThan(Level.INFO)) {
             while (e != null) {
-                logger.error(e);
+                String cause = logger.getMessageFactory().newMessage(e).getFormattedMessage();
+                if (!cause.equals(message)) {
+                    logger.error(e);
+                }
+
+                message = cause;
                 e = e.getCause();
             }
         }

diff --git a/citydb-cli/src/main/resources/org/citydb/cli/application.properties b/citydb-cli/src/main/resources/org/citydb/cli/application.properties
@@ -1,23 +1,3 @@
-#
-# citydb-tool - Command-line tool for the 3D City Database
-# https://www.3dcitydb.org/
-#
-# Copyright 2022-2024
-# virtualcitysystems GmbH, Germany
-# https://vc.systems/
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
 name=@name@
 version=@version@
 copyrightYear=@copyrightYear@

diff --git a/citydb-config/src/main/java/org/citydb/config/ConfigException.java b/citydb-config/src/main/java/org/citydb/config/ConfigException.java
@@ -24,7 +24,6 @@
 public class ConfigException extends Exception {
 
     public ConfigException() {
-        super();
     }
 
     public ConfigException(String message) {

diff --git a/citydb-database/src/main/java/org/citydb/database/DatabaseException.java b/citydb-database/src/main/java/org/citydb/database/DatabaseException.java
@@ -24,7 +24,6 @@
 public class DatabaseException extends Exception {
 
     public DatabaseException() {
-        super();
     }
 
     public DatabaseException(String message) {

diff --git a/citydb-database/src/main/java/org/citydb/database/adapter/DatabaseAdapterException.java b/citydb-database/src/main/java/org/citydb/database/adapter/DatabaseAdapterException.java
@@ -24,7 +24,6 @@
 public class DatabaseAdapterException extends Exception {
 
     public DatabaseAdapterException() {
-        super();
     }
 
     public DatabaseAdapterException(String message) {

diff --git a/citydb-database/src/main/java/org/citydb/database/geometry/GeometryException.java b/citydb-database/src/main/java/org/citydb/database/geometry/GeometryException.java
@@ -24,7 +24,6 @@
 public class GeometryException extends Exception {
 
     public GeometryException() {
-        super();
     }
 
     public GeometryException(String message) {

diff --git a/citydb-database/src/main/java/org/citydb/database/schema/SchemaException.java b/citydb-database/src/main/java/org/citydb/database/schema/SchemaException.java
@@ -24,7 +24,6 @@
 public class SchemaException extends Exception {
 
     public SchemaException() {
-        super();
     }
 
     public SchemaException(String message) {

diff --git a/citydb-database/src/main/java/org/citydb/database/srs/SrsException.java b/citydb-database/src/main/java/org/citydb/database/srs/SrsException.java
@@ -24,7 +24,6 @@
 public class SrsException extends Exception {
 
     public SrsException() {
-        super();
     }
 
     public SrsException(String message) {

diff --git a/citydb-io-citygml/src/main/java/org/citydb/io/citygml/builder/ModelBuildException.java b/citydb-io-citygml/src/main/java/org/citydb/io/citygml/builder/ModelBuildException.java
@@ -24,7 +24,6 @@
 public class ModelBuildException extends Exception {
 
     public ModelBuildException() {
-        super();
     }
 
     public ModelBuildException(String message) {

diff --git a/...db-io-citygml/src/main/java/org/citydb/io/citygml/serializer/ModelSerializeException.java b/...db-io-citygml/src/main/java/org/citydb/io/citygml/serializer/ModelSerializeException.java
@@ -24,7 +24,6 @@
 public class ModelSerializeException extends Exception {
 
     public ModelSerializeException() {
-        super();
     }
 
     public ModelSerializeException(String message) {

diff --git a/citydb-io/src/main/java/org/citydb/io/IOAdapterException.java b/citydb-io/src/main/java/org/citydb/io/IOAdapterException.java
@@ -24,7 +24,6 @@
 public class IOAdapterException extends Exception {
 
     public IOAdapterException() {
-        super();
     }
 
     public IOAdapterException(String message) {

diff --git a/citydb-io/src/main/java/org/citydb/io/reader/ReadException.java b/citydb-io/src/main/java/org/citydb/io/reader/ReadException.java
@@ -24,7 +24,6 @@
 public class ReadException extends Exception {
 
     public ReadException() {
-        super();
     }
 
     public ReadException(String message) {

diff --git a/citydb-io/src/main/java/org/citydb/io/reader/filter/FilterException.java b/citydb-io/src/main/java/org/citydb/io/reader/filter/FilterException.java
@@ -24,7 +24,6 @@
 public class FilterException extends Exception {
 
     public FilterException() {
-        super();
     }
 
     public FilterException(String message) {

diff --git a/citydb-io/src/main/java/org/citydb/io/validator/ValidateException.java b/citydb-io/src/main/java/org/citydb/io/validator/ValidateException.java
@@ -24,7 +24,6 @@
 public class ValidateException extends Exception {
 
     public ValidateException() {
-        super();
     }
 
     public ValidateException(String message) {

diff --git a/citydb-io/src/main/java/org/citydb/io/writer/WriteException.java b/citydb-io/src/main/java/org/citydb/io/writer/WriteException.java
@@ -24,7 +24,6 @@
 public class WriteException extends Exception {
 
     public WriteException() {
-        super();
     }
 
     public WriteException(String message) {

diff --git a/citydb-operation/src/main/java/org/citydb/operation/deleter/DeleteException.java b/citydb-operation/src/main/java/org/citydb/operation/deleter/DeleteException.java
@@ -24,7 +24,6 @@
 public class DeleteException extends Exception {
 
     public DeleteException() {
-        super();
     }
 
     public DeleteException(String message) {

diff --git a/citydb-operation/src/main/java/org/citydb/operation/exporter/ExportException.java b/citydb-operation/src/main/java/org/citydb/operation/exporter/ExportException.java
@@ -24,7 +24,6 @@
 public class ExportException extends Exception {
 
     public ExportException() {
-        super();
     }
 
     public ExportException(String message) {

diff --git a/citydb-operation/src/main/java/org/citydb/operation/importer/ImportException.java b/citydb-operation/src/main/java/org/citydb/operation/importer/ImportException.java
@@ -24,7 +24,6 @@
 public class ImportException extends Exception {
 
     public ImportException() {
-        super();
     }
 
     public ImportException(String message) {

diff --git a/citydb-plugin/src/main/java/org/citydb/plugin/PluginException.java b/citydb-plugin/src/main/java/org/citydb/plugin/PluginException.java
@@ -24,7 +24,6 @@
 public class PluginException extends Exception {
 
     public PluginException() {
-        super();
     }
 
     public PluginException(String message) {

diff --git a/citydb-query/src/main/java/org/citydb/query/builder/QueryBuildException.java b/citydb-query/src/main/java/org/citydb/query/builder/QueryBuildException.java
@@ -24,7 +24,6 @@
 public class QueryBuildException extends Exception {
 
     public QueryBuildException() {
-        super();
     }
 
     public QueryBuildException(String message) {

diff --git a/citydb-query/src/main/java/org/citydb/query/builder/schema/SchemaPathException.java b/citydb-query/src/main/java/org/citydb/query/builder/schema/SchemaPathException.java
@@ -24,7 +24,6 @@
 public class SchemaPathException extends Exception {
 
     public SchemaPathException() {
-        super();
     }
 
     public SchemaPathException(String message) {

diff --git a/citydb-query/src/main/java/org/citydb/query/filter/encoding/FilterParseException.java b/citydb-query/src/main/java/org/citydb/query/filter/encoding/FilterParseException.java
@@ -24,7 +24,6 @@
 public class FilterParseException extends Exception {
 
     public FilterParseException() {
-        super();
     }
 
     public FilterParseException(String message) {

diff --git a/citydb-util/src/main/java/org/citydb/util/csv/IdListException.java b/citydb-util/src/main/java/org/citydb/util/csv/IdListException.java
@@ -24,7 +24,6 @@
 public class IdListException extends Exception {
 
     public IdListException() {
-        super();
     }
 
     public IdListException(String message) {

diff --git a/citydb-util/src/main/java/org/citydb/util/tiling/TilingException.java b/citydb-util/src/main/java/org/citydb/util/tiling/TilingException.java
@@ -24,7 +24,6 @@
 public class TilingException extends Exception {
 
     public TilingException() {
-        super();
     }
 
     public TilingException(String message) {