Skip to content

Commit

Permalink
Correctly scop app key & fix integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
baksetercx committed Dec 13, 2024
1 parent 0cb5afc commit f9ed776
Show file tree
Hide file tree
Showing 6 changed files with 54 additions and 18 deletions.
12 changes: 8 additions & 4 deletions .github/workflows/example-build-deploy-dockerfile-google.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -83,8 +84,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -129,8 +131,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -175,8 +178,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/example-build-deploy-dockerfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -83,8 +84,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -127,8 +129,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -171,8 +174,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/example-build-deploy-dotnet-google.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -77,6 +78,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -115,6 +117,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand All @@ -129,6 +132,8 @@ jobs:
system: ${{ env.SYSTEM_NAME }}
# START REMOVE FROM EXAMPLE
checkout: 'false'
env:
BASE_URL: 'https://core.dev-elvia.io/demo-api'
# END REMOVE FROM EXAMPLE

build-scan:
Expand All @@ -154,6 +159,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -199,6 +205,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -245,6 +252,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -291,6 +299,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/example-build-deploy-dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -77,6 +78,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -115,6 +117,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand All @@ -129,6 +132,8 @@ jobs:
system: ${{ env.SYSTEM_NAME }}
# START REMOVE FROM EXAMPLE
checkout: 'false'
env:
BASE_URL: 'https://core.dev-elvia.io/demo-api'
# END REMOVE FROM EXAMPLE

build-scan:
Expand All @@ -154,6 +159,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -199,6 +205,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -243,6 +250,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -287,6 +295,7 @@ jobs:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/example-build-deploy-go-google.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -77,8 +78,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -120,8 +122,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -166,8 +169,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -212,8 +216,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/example-build-deploy-go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -77,8 +78,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -120,8 +122,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -164,8 +167,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -208,8 +212,9 @@ jobs:
id: app-token
with:
app-id: ${{ vars.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
repositories: 'core'

- name: Checkout core repository
uses: actions/checkout@v4
Expand Down

0 comments on commit f9ed776

Please sign in to comment.