Framework working with Carthage and CocoaPods. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BogdanTC
requested review from
dmacra,
david-livadaru-3pillarglobal,
flaviu88 and
ValentinaIancu3PG
AutoCompletion.podspec
Outdated
| s.platform = :ios, "9.0" | ||
| s.source = { :git => "https://github.com/3pillarlabs/ios-autocomplete.git", :tag => "#{s.version}" } | ||
| s.source_files = "Framework/AutoCompletion/AutoCompletion", "Framework/AutoCompletion/AutoCompletion/**/*.{h,m}" | ||
| s.exclude_files = "Classes/Exclude" |
There was a problem hiding this comment.
Remove exclude_files, does not seem to be needed.
AutoCompletion.podspec
Outdated
| s.version = "1.2.1" | ||
| s.summary = "Text auto completion framework." | ||
| s.description = "Library can be used via cocoapods in any project." | ||
| s.homepage = "https://github.com/3pillarlabs/ios-autocomplete/tree/AutoCompleteFramework" |
There was a problem hiding this comment.
https://github.com/3pillarlabs/ios-autocompleteshould be the home page.
Podspec and readme updated.
|
Since we're providing the framework through dependency managers, we should remove the compiled framework since that was causing the in issue #18. |
david-livadaru-3pillarglobal
approved these changes
Oct 20, 2017
Removed compiled framework and updated readme file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Framework functional with dependency managers(CocoaPods/Carthage), demo app removed from branch.