Skip to content

Replace 'stout::Try' with 'tl::expected' #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Replace 'stout::Try' with 'tl::expected' #61

wants to merge 2 commits into from

Conversation

@ArthurBandaryk
Copy link
Contributor

@ArthurBandaryk ArthurBandaryk commented Jul 26, 2022

This PR replaces stout::Try with stout::expected which is just going to be an alias for tl::expected.

@ArthurBandaryk ArthurBandaryk self-assigned this Jul 26, 2022
@ArthurBandaryk ArthurBandaryk marked this pull request as draft July 26, 2022 16:02
benh
benh reviewed Jul 27, 2022
View reviewed changes
@ArthurBandaryk ArthurBandaryk force-pushed the artur.expected branch 2 times, most recently from 2420a71 to 0e35234 Compare July 27, 2022 07:16
CodingCanuck
CodingCanuck approved these changes Jul 27, 2022
View reviewed changes
CodingCanuck
CodingCanuck approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@CodingCanuck CodingCanuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artur, is it intentional that this review is still in draft state?

@ArthurBandaryk
Copy link
Contributor Author

ArthurBandaryk commented Jul 27, 2022

Artur, is it intentional that this review is still in draft state?

Yep, because 3-rd phase with all replacement in 'include/stout' and 'tests' dirs is coming!

CodingCanuck
CodingCanuck approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@CodingCanuck CodingCanuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I love how there's a lot less explicit use of std::string in the test in this latest revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benh benh benh left review comments

+1 more reviewer

@CodingCanuck CodingCanuck CodingCanuck approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@ArthurBandaryk ArthurBandaryk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArthurBandaryk @benh @CodingCanuck