[THREESCALE-11610] Remove "$id" from the json schema #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkan145
changed the title
|
For reference, I created a new policy list based on this PR and provided it to Joan. Joan confirmed that it would work with both the old and new codebases, i.e. no compatibility issues. |
tkan145
force-pushed
the
THREESCALE-11610-jsonschema
branch
from
bca7954 to
9cb9727
Compare
|
Thanks for working on this @tkan145. Please give me a heads up when this is deployed to SaaS. |
eguzki
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix https://issues.redhat.com/browse/THREESCALE-11610
More details here 3scale/porta#3968 (comment)
Verification
We only need the CI to pass and we good to merge