Skip to content

Commit

Permalink
Merge pull request #3960 from 3scale/fix-rspec-proxy-config
Browse files Browse the repository at this point in the history
Fix RSpecs for Proxy API
  • Loading branch information
mayorova authored Jan 13, 2025
2 parents 5562acb + 6ecfe99 commit 05e870c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions spec/acceptance/api/proxy_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
get '/admin/api/services/:service_id/proxy.:format', action: :show

put '/admin/api/services/:service_id/proxy.:format', action: :update do
# stubbing the subscriber to avoid changing the 'updated_at' timestamp on Proxy
before { allow_any_instance_of(ProxyConfigEventSubscriber).to receive(:call) }

parameter :credentials_location, 'Credentials Location'
parameter :api_backend, 'Private endpoint'
parameter :jwt_claim_with_client_id, 'JWT Claim with ClientID Location'
Expand Down
2 changes: 1 addition & 1 deletion test/unit/finance/billing_strategy_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def setup
canaries = FactoryBot.create_list(:provider_with_billing, 4).map(&:id)
ThreeScale.config.payments.expects(:billing_canaries).at_least_once.returns(canaries)

Finance::BillingStrategy.expects(:daily_async).with { |scope| assert_equal canaries, scope.pluck(:account_id) }.returns(true)
Finance::BillingStrategy.expects(:daily_async).with { |scope| assert_same_elements canaries, scope.pluck(:account_id) }.returns(true)
assert Finance::BillingStrategy.daily_canaries
end

Expand Down

0 comments on commit 05e870c

Please sign in to comment.