Merge pull request #3953 from 3scale/THREESCALE-11500_fix-confusing-d…

…esign-flaw-in-promote-ui THREESCALE-11500: Fix confusing design flaw in "promote" UI (Part 1)
3scale · Jan 9, 2025 · a3461ff · a3461ff
2 parents 42acfd9 + 7b03258
commit a3461ff
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 47 deletions.
diff --git a/app/subscribers/proxy_config_event_subscriber.rb b/app/subscribers/proxy_config_event_subscriber.rb
@@ -3,8 +3,11 @@
 class ProxyConfigEventSubscriber
   def call(event)
     case event
-    when ProxyConfigs::AffectingObjectChangedEvent then ProxyConfigAffectingChangeWorker.perform_later(event.event_id)
-    else raise "Unknown event type #{event.class}"
+    when ProxyConfigs::AffectingObjectChangedEvent
+      proxy = Proxy.find(event.proxy_id)
+      proxy.affecting_change_history.touch
+    else
+      raise "Unknown event type #{event.class}"
     end
   end
 end
diff --git a/app/workers/proxy_config_affecting_change_worker.rb b/app/workers/proxy_config_affecting_change_worker.rb
diff --git a/test/subscribers/proxy_config_event_subscriber_test.rb b/test/subscribers/proxy_config_event_subscriber_test.rb
@@ -8,7 +8,9 @@ class ProxyConfigEventSubscriberTest < ActiveSupport::TestCase
     proxy_rule = FactoryBot.build_stubbed(:proxy_rule, proxy: proxy)
     event = ProxyConfigs::AffectingObjectChangedEvent.create(proxy, proxy_rule)
 
-    ProxyConfigAffectingChangeWorker.expects(:perform_later).with(event.event_id)
+    Proxy.stubs(:find).with(event.proxy_id).returns(proxy)
+
+    proxy.affecting_change_history.expects(:touch)
 
     ProxyConfigEventSubscriber.new.call(event)
   end

diff --git a/test/workers/proxy_config_affecting_change_worker_test.rb b/test/workers/proxy_config_affecting_change_worker_test.rb