THREESCALE-8735: Client secret in clear text in the API Manager UI (RH SSO Integration) Part 2 #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvillen
force-pushed
the
THREESCALE-8735_SSO-Integration-admin-side
branch
from
2ca0f61
to
bf3ec00
Compare
jlledom
reviewed
Aug 6, 2024
lvillen
force-pushed
the
THREESCALE-8735_SSO-Integration-admin-side
branch
2 times, most recently
from
cdeed21
to
9aef015
Compare
jlledom
reviewed
Aug 8, 2024
mayorova
force-pushed
the
THREESCALE-8735_SSO-Integration-admin-side
branch
from
9aef015
to
09fed84
Compare
jlledom
reviewed
Aug 28, 2024
lvillen
force-pushed
the
THREESCALE-8735_SSO-Integration-admin-side
branch
from
e187526
to
ca36747
Compare
jlledom
previously approved these changes
Aug 30, 2024
lvillen
force-pushed
the
THREESCALE-8735_SSO-Integration-admin-side
branch
from
ca36747
to
d80e10e
Compare
lvillen
force-pushed
the
THREESCALE-8735_SSO-Integration-admin-side
branch
from
d80e10e
to
eeaf89d
Compare
jlledom
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, our admin SSO Integrations display the client secret when checking an integration as long as when editing or creating a new one.
Which issue(s) this PR fixes
THREESCALE-8735. This second part applies Patternfly and masks the client secret at the Admin SSO Integration new and edit forms.
Before
New
Edit
After
New
Edit
More details and snapshots to come related to developer portal changes