Added a @notImpersonating blade directive #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @otrigg, thank you for your PR. Let me check that and I'll merge it :) |
drbyte
reviewed
Jan 29, 2021
| $this->assertStringNotContainsString('Not impersonating this user', $this->view); | ||
| $this->admin->leaveImpersonation(); | ||
| $this->logout(); | ||
| } |
There was a problem hiding this comment.
The other tests don't call ->impersonate and ->leaveImpersonation, so I wonder if it would make sense to add another assertion to ensure that after leaving impersonation the Not Impersonating message re-appears?
|
This is something that really would be useful. Any chance of it getting merged? |
|
Hi, what is blocking this merge? Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a "@notImpersonating" blade directive.
I found this enhancement proposal and I decided to contribute.