Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for php 8.4 #211

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Support for php 8.4 #211

merged 1 commit into from
Dec 18, 2024

Conversation

MarioGattolla
Copy link
Contributor

Hi this pull request close #209

Tell me if something wrong

@MarceauKa
Copy link
Member

@MarioGattolla I'm looking for why tests are not running

@aglipanci
Copy link

aglipanci commented Dec 9, 2024

@MarceauKa based on the error logs it seems like you need to enable external actions on your repository settings at Repository Settings → Actions → General.
Screenshot 2024-12-09 at 16 46 50

@calebdw
Copy link

calebdw commented Dec 9, 2024

@MarceauKa, can we try to merge this? We're updating to PHP8.4 and these deprecation warnings are messing up our json endpoints

@sebastiansulinski
Copy link

Any indication on when will this be merged please?

@ainesophaur
Copy link

fwiw, if anyone needs to use this branch ahead of time you can update your composer json to use the fork

{
  "repositories": [
      {
          "type": "github",
          "url": "https://github.com/MarioGattolla/laravel-impersonate"
      }
  ],
  "require": {
     "lab404/laravel-impersonate": "dev-master as 1.7.5",
  }
}

@MarceauKa MarceauKa merged commit f3c98b0 into 404labfr:master Dec 18, 2024
1 check was pending
@aglipanci
Copy link

@MarceauKa can you please release a new version so we can use this?

@MarceauKa
Copy link
Member

@aglipanci Yep, I'm reviewing #207 and I'll release it

@aglipanci
Copy link

Thank you! It's appreciated that you are taking the time for this :)

@it-can
Copy link

it-can commented Dec 23, 2024

@MarceauKa can you just do a quick release/tag so we can run php8.4 :-)

@drbyte drbyte mentioned this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.4 support
7 participants