Make actionEvent of extension more specific #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a warning in the
package.json
about theactivationEvent
:Using '*' activation is usually a bad idea as it impacts performance.
As explained in the vscode docs, the
*
corresponds to 'always activate'.This PR makes this actionEvent more specific. Ideally, the extension should only be activated for
json
andyaml
files using onLanguage:However the
deleteYamlNode
test case is failing then. Maybe it would make sense that someone with more experience of this project (@ak1394 ?) could take a look in a second step to improve this further