Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new endpoint - List Emails #902

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Add new endpoint - List Emails #902

merged 2 commits into from
Feb 6, 2024

Conversation

john-joe-givery
Copy link
Contributor

Adds new endpoint to retrieve all emails (public and private) associated with the authenticated user (requires user:email scope)

BenFradet
BenFradet previously approved these changes Feb 6, 2024
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@fedefernandez
Copy link
Contributor

Thanks! Do you mind to add the following in the build.sbt (here):

ProblemFilters.exclude[ReversedMissingMethodProblem]("github4s.algebras.Users.getEmails")

@fedefernandez fedefernandez added the breaking-change A breaking change that needs to be treated with consideration label Feb 6, 2024
@fedefernandez fedefernandez merged commit ecbab9e into 47degrees:main Feb 6, 2024
1 check passed
@fedefernandez
Copy link
Contributor

Thanks for your contribution, @john-joe-givery. I'll release a new version soon

@john-joe-givery
Copy link
Contributor Author

Thanks for the approval! What's the status on the new release? I noticed the CI on the master merge failed. Is there something I can do to assist in getting it released?

@john-joe-givery
Copy link
Contributor Author

FYI after this was merged in, the microsite no longer seems to be working. I'm not sure if that's related to this change, but it might be good to look into when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change that needs to be treated with consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants