Add support for autodetecting EKS when IMDSv2 is in use #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this. I will review shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of autodetect will only successfully autodetect EKS when using version one of the Instance Metadata Service. This pull request adds the ability for autodetect to work correctly when IMDSv2 is in use, which is default for EKS Managed Nodes, and encouraged by defaults in cfn templates for self managed nodes.
Luckily - the AWS SDK for Go appears to seamlessly handle this (which I found out by manually specifying the provider. So it appears only the autodetect functionality needed to change.
Lastly - I am newish to Go, so please let me know if you would like any changes/adjustments to the code. I tried my best to honor the original pattern :)
https://aws.amazon.com/about-aws/whats-new/2020/08/amazon-eks-supports-ec2-instance-metadata-service-v2/
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html#instance-metadata-v2-how-it-works