Skip to content

Commit

Permalink
Merge pull request #125 from tommygonzaleza/patch-1
Browse files Browse the repository at this point in the history
Solve video problem
  • Loading branch information
alesanchezr authored Nov 15, 2023
2 parents 150b166 + 4e5c140 commit 8aa2387
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion exercises/14-video-tag/README.es.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ El tag de `<video>` se utiliza para incluir un contenido de video dentro de un d
## 📝 Instrucciones:

1. Usa el tag `<video>` para incluir este video en el sitio web: [https://assets.breatheco.de/apis/video/why-pair-programming](https://assets.breatheco.de/apis/video/why-pair-programming).
1. Usa el tag `<video>` para incluir este video en el sitio web: `https://github.com/breatheco-de/assets-old/blob/bb5870b89e029884360641b544665bcb037ef437/apis/video/videos/4geeks-background.mp4?raw=true`.

2. El video debe cubrir todo el sitio web, para ello vamos a aplicarle un `width="100%"` y un `height="100%"`.

Expand Down
2 changes: 1 addition & 1 deletion exercises/14-video-tag/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ The `<video>` tag is used to include video content within a document.
## 📝 Instructions:

1. Use the `<video>` tag to include this video on the website: [https://assets.breatheco.de/apis/video/why-pair-programming](https://assets.breatheco.de/apis/video/why-pair-programming).
1. Use the `<video>` tag to include this video on the website: `https://github.com/breatheco-de/assets-old/blob/bb5870b89e029884360641b544665bcb037ef437/apis/video/videos/4geeks-background.mp4?raw=true`.

2. The video must cover the entire website, for this we are going to apply a `width="100%"` and a `height="100%"`.

Expand Down
4 changes: 2 additions & 2 deletions exercises/14-video-tag/solution.hide.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<body style="margin: 0">
<!-- your code here -->
<video width="100%" height="100%" autoplay muted>
<source src="https://assets.breatheco.de/apis/video/why-pair-programming" />
<source src="https://github.com/breatheco-de/assets-old/blob/bb5870b89e029884360641b544665bcb037ef437/apis/video/videos/4geeks-background.mp4?raw=true" />
</video>
</body>
</html>
</html>
4 changes: 2 additions & 2 deletions exercises/14-video-tag/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ it('The <source> tag should have the expected video in the "src" attribute.', fu

let source = video.querySelector("source");
expect(source).toBeTruthy();
expect(source.src).toBe("https://assets.breatheco.de/apis/video/why-pair-programming")
})
expect(source.src).toBe("https://github.com/breatheco-de/assets-old/blob/bb5870b89e029884360641b544665bcb037ef437/apis/video/videos/4geeks-background.mp4?raw=true")
})

0 comments on commit 8aa2387

Please sign in to comment.