Merge pull request #137 from josemoracard/jose4-07.2-letter-counter

exercises 07.2-letter-counter to 14-divide-and-conquer

Author: alesanchezr

exercises/07.2-Letter-Counter/README.es.md

@@ -1,8 +1,8 @@
-# `07.2` Contador de letras
+# `07.2` Letter Counter
 
 Nuestro cliente necesita un programa que cuente las repeticiones de las letras en un string dado. Sé que es extraño, pero es muy testarudo ¡Lo necesitamos lo antes posible!
 
-## :pencil: Instrucciones:
+## 📝 Instrucciones:
 
 1. Crea un objeto donde las letras son las propiedades y los valores son el número de veces que esa letra se repite en toda la cadena. 
 
@@ -14,7 +14,7 @@ const word = "Hello World";
 // Debería imprimir en la consola { h: 1, e: 1, l: 3, o: 2, w: 1, r: 1, d: 1 }
 ```
 
-## :bulb: Pista:
+## 💡 Pistas:
 
 + Recorre todo el string (usa un bucle).
 

exercises/07.2-Letter-Counter/README.md

@@ -1,14 +1,12 @@
 ---
-
 tutorial: https://www.youtube.com/watch?v=oLTidCuisew
-
 ---
 
 # `07.2` Letter Counter
 
-Our customer needs a program that counts the number of occurences of each letter in a given string. I know that's weird, but they are very adamant. We need this asap! 
+Our customer needs a program that counts the number of occurrences of each letter in a given string. I know that's weird, but they are very adamant. We need this asap! 
 
-## :pencil: Instructions:
+## 📝 Instructions:
 
 1. Create an object where the letters are the properties and the values are the number of times that letter is repeated throughout the string. 
 
@@ -20,16 +18,16 @@ const word = "Hello World";
 // The console should print { h: 1, e: 1, l: 3, o: 2, w: 1, r: 1, d: 1 }
 ```
 
-## :bulb: Hint
+## 💡 Hints:
 
 + Loop the entire string.
 
-+ On every iteration check if the object `counts` has the letter initialized as a property.
++ On every iteration, check if the object `counts` has the letter initialized as a property.
 
 + If the letter has not been initialized, then do it and set its value equal to 1 (first time found).
 
-+ If it was already initialized just increment the property value by one.
++ If it was already initialized, just increment the property value by one.
 
 + Remember to ignore white spaces in the string.
 
-+ You should lower case all letters to have an accurate count of all letters regardless of casing of the letter.
++ To accurately count all letters, regardless of their casing, you should convert all letters to lowercase.

exercises/07.2-Letter-Counter/app.js

@@ -1,6 +1,6 @@
 let par = "Lorem ipsum dolor sit amet consectetur adipiscing elit Curabitur eget bibendum turpis Curabitur scelerisque eros ultricies venenatis mi at tempor nisl Integer tincidunt accumsan cursus"
 let counts = {};
 
-// your code here
+// Your code here
 
-console.log(counts);
+console.log(counts);

exercises/07.2-Letter-Counter/solution.hide.js

@@ -1,20 +1,16 @@
 let par = "Lorem ipsum dolor sit amet consectetur adipiscing elit Curabitur eget bibendum turpis Curabitur scelerisque eros ultricies venenatis mi at tempor nisl Integer tincidunt accumsan cursus"
 let counts = {};
 
-// your code here
-for(let i in par){
+// Your code here
+for(let i in par) {
     const letter = par[i].toLowerCase();
-    console.log(letter);
     if(letter == " ") continue;
-    else if(counts[letter] == undefined){
-        console.log("Found "+letter+" for the first time")
+    else if(counts[letter] == undefined) {
         counts[letter] = 1;
     } 
-    else{
-        console.log("Found "+letter+" more than once")
+    else {
         counts[letter] = counts[letter] + 1;
-        
     }
 }
 
-console.log(counts);
+console.log(counts);

exercises/07.2-Letter-Counter/tests.js

@@ -13,7 +13,7 @@ it('You have to use the console.log function once, at the end of the exercise',
     expect(console.log.mock.calls.length).toBe(1);
 });
 
-it('Use a for loop', function () {
+it('Use a "for" loop', function () {
     const app_content = fs.readFileSync(path.resolve(__dirname, './app.js'), 'utf8');
     expect(app_content).toMatch(/for(\s*)\(/);
 });
@@ -37,4 +37,4 @@ it('Create the object with the letter counts like { a: 1, b: 4, ... }', function
     }
 
     expect(counts).toEqual(_counts);
-});
+});

exercises/07.3-Flip-Array/README.es.md

@@ -1,18 +1,18 @@
-# `07.3` Invierte el Array
+# `07.3` Flip Array
 
-## :pencil: Instrucciones: 
+## 📝 Instrucciones: 
 
-1. Usando un bucle `for`, invierte el arreglo o array `arr` e imprime el nuevo arreglo o array en la consola.
+1. Usando un bucle `for`, invierte el array `arr` e imprime el nuevo array en la consola.
 
 Por ejemplo:
 
 ```js
- array inicial:  [45, 67, 87, 23, 5,  32, 60]; array array final :    [60, 32, 5 , 23, 87, 67, 45];
+Initial array:  [45, 67, 87, 23, 5, 32, 60];
+Final array:    [60, 32, 5, 23, 87, 67, 45];
 ```
 
-## :bulb: Pista
+## 💡 Pistas:
 
 + Debes recorrer todo el arreglo [desde el final hasta el principio](https://stackoverflow.com/questions/1340589/are-loops-really-faster-in-reverse).
 
-+ En cada bucle, inserta todos los elementos (a 
-medida que avanza) en un nuevo array o arreglo, este será tu arreglo invertido.
++ En cada bucle, inserta todos los elementos (a medida que avanza) en un nuevo array, este será tu arreglo invertido. ¿Qué otros métodos puedes usar además de `push()`?

exercises/07.3-Flip-Array/README.md

@@ -4,19 +4,19 @@ tutorial: https://www.youtube.com/watch?v=Snn7OtZY370
 
 # `07.3` Flip Array
 
-## :pencil: Instructions: 
+## 📝 Instructions: 
 
 1. Using a `for` loop, invert the `arr` array and print the new array on the console. 
 
 For example:
 
 ```js
-Initial array:  [45, 67, 87, 23, 5,  32, 60];
-Final array:    [60, 32, 5 , 23, 87, 67, 45];
+Initial array:  [45, 67, 87, 23, 5, 32, 60];
+Final array:    [60, 32, 5, 23, 87, 67, 45];
 ```
 
-## :bulb: Hint
+## 💡 Hints:
 
-+ You should loop the entire array [from the end to the beggining](https://stackoverflow.com/questions/1340589/are-loops-really-faster-in-reverse).
++ You should loop the entire array [from the end to the beginning](https://stackoverflow.com/questions/1340589/are-loops-really-faster-in-reverse).
 
-+ On each loop push all the items (as you go) into a new array, this will be your flipped array. What other methods can you use besides `push()`?
++ On each loop, push all the items (as you go) into a new array, this will be your flipped array. What other methods can you use besides `push()`?

exercises/07.3-Flip-Array/app.js

@@ -1,3 +1,3 @@
 let arr = [45,67,87,23,5,32,60];
 
-//Your code here.
+// Your code here

exercises/07.3-Flip-Array/solution.hide.js

@@ -1,9 +1,10 @@
 let arr = [45,67,87,23,5,32,60];
 
-//Your code here.
+// Your code here
 let flippedArray = []
-for(let i = arr.length - 1; i>= 0;i--){
+for(let i = arr.length - 1; i >= 0; i--) {
     let item = arr[i];
     flippedArray.push(item);
 }
-console.log(flippedArray)
+
+console.log(flippedArray)

exercises/07.3-Flip-Array/tests.js

@@ -9,28 +9,23 @@ global.console.log = console.log = jest.fn((text) => _buffer += text + "\n");
 let reverse = Array.prototype.reverse;
 Array.prototype.reverse = jest.fn(function(){ return this; });
 
-it('Use the console.log function once to print the new array with the types on the console', function () {
+it('Use the console.log function once, at the end of the exercise', function () {
     const app = require('./app.js');
     expect(console.log.mock.calls.length).toBe(1);
 });
 
-it("Use the typeof function inside the loop", function () {
-    const app_content = fs.readFileSync(path.resolve(__dirname, './app.js'), 'utf8');
-    expect(app_content).not.toMatch(/\.typeof/);
-});
-
-it('There needs to be a variable called arr with the original array', function () {
+it('There needs to be a variable called "arr" with the original array', function () {
     const _app = rewire('./app.js');
     const variable = _app.__get__('arr');
     expect(variable).toBeTruthy();
 });
 
-it('Loop the array in a reverse order and console.log all of its item', function () {
+it('Loop the array in a reverse order and console.log all of its items', function () {
     const _app = rewire('./app.js');
     const variable = _app.__get__('arr');
     let inverted = [];
     for(let i = variable.length-1; i>=0;i--){
         inverted.push(variable[i]);
     }
     expect(_buffer).toMatch(inverted.map(n => n).join(","));
-});
+});