Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create QuickSort.java #16

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Create QuickSort.java #16

merged 4 commits into from
Oct 3, 2022

Conversation

ayusshrathore
Copy link
Contributor

No description provided.

AnirudhDaya
AnirudhDaya requested changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@AnirudhDaya AnirudhDaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code. But do add the explanation of the algorithm as well the time and space complexities

@AnirudhDaya AnirudhDaya linked an issue Oct 1, 2022 that may be closed by this pull request
Sorting Algorithms #4
Open
@AnirudhDaya AnirudhDaya added enhancement New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 1, 2022
@ayusshrathore
Copy link
Contributor Author

Hey mate,

I closed the pull request by mistake, kindly review the changes and merge accordingly.

@ayusshrathore ayusshrathore reopened this Oct 2, 2022
ayusshrathore
ayusshrathore commented Oct 2, 2022
View reviewed changes
Copy link
Contributor Author

@ayusshrathore ayusshrathore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey mate,

Thanks for reviewing the code and pointing out things. I've added the explanation and complexities for the algorithm. Do have a look and let me know if something's missing.

Happy merging :)

AnirudhDaya
AnirudhDaya approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@AnirudhDaya AnirudhDaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work buddy! Merging this one.

@AnirudhDaya AnirudhDaya removed a link to an issue Oct 3, 2022
Sorting Algorithms #4
Open
@AnirudhDaya AnirudhDaya merged commit b38e182 into 4N1Z:main Oct 3, 2022
@AnirudhDaya AnirudhDaya mentioned this pull request Oct 3, 2022
Merged
@4N1Z 4N1Z added the hacktoberfest-accepted This PR has been accepted as a hacktoberfest PR label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnirudhDaya AnirudhDaya AnirudhDaya approved these changes

Assignees

@ayusshrathore ayusshrathore

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted This PR has been accepted as a hacktoberfest PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayusshrathore @AnirudhDaya @4N1Z