Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added binary search in c++.cpp #20

Closed
wants to merge 1 commit into from
Closed

Added binary search in c++.cpp #20

wants to merge 1 commit into from

Conversation

Lahari03
Copy link

@Lahari03 Lahari03 commented Oct 1, 2022

In this file, I've written the code for binary search in c++ language.
Please take a look and provide the hacktoberfest-accepted label.

@AnirudhDaya
Copy link
Collaborator

Buddy, please name your PR properly next time around. It should be of a format similar to "Added binary search in c++"

@AnirudhDaya AnirudhDaya added good first issue Good for newcomers enhancement New feature or request Hacktoberfest labels Oct 1, 2022
@AnirudhDaya AnirudhDaya linked an issue Oct 1, 2022 that may be closed by this pull request
Searching Algortihms #3
Open
4N1Z
4N1Z requested changes Oct 1, 2022
View reviewed changes
Copy link
Owner

@4N1Z 4N1Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Pal,
Glad to see your contribution 😄
Points to change :

  • Add description in the file
  • -Add the details of Binary Search as documentation
    -The details should include :
    --What is Binary Search? (or How it works)
    --Time and space complexity

Happy Coding !

@Lahari03 Lahari03 changed the title Create In CPP.cpp Added binary search in c++.cpp Oct 2, 2022
@AnirudhDaya AnirudhDaya added duplicate This issue or pull request already exists and removed enhancement New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 14, 2022
@AnirudhDaya AnirudhDaya removed a link to an issue Oct 14, 2022
Searching Algortihms #3
Open
@AnirudhDaya
Copy link
Collaborator

Sorry buddy, code already exists

@Lahari03 Lahari03 deleted the Searching-Algorithms branch October 26, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4N1Z 4N1Z 4N1Z requested changes

Assignees

@Lahari03 Lahari03

Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lahari03 @AnirudhDaya @4N1Z