Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Manifest URL #14

Merged
merged 10 commits into from
Jun 25, 2024
Merged

[FIX] Manifest URL #14

merged 10 commits into from
Jun 25, 2024

Conversation

anonhostpi
Copy link
Contributor

Corrects the manifest URL to use the same URL that Obsidian does, which is the one on the Release Asset

Describe your changes

  • changes fetchReleases() to populate releases with a manifest_url
  • changes fetchManifest() to accept a manifest_url

Related Issues

Fixes #12

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation N/A
  • My code fixes the feature discussed in Related Issues

@anonhostpi anonhostpi marked this pull request as ready for review June 25, 2024 00:57
@anonhostpi
Copy link
Contributor Author

I've already run your workflows on my fork: anonhostpi#2

  • they ran successfully.

I've also already tested the changes on my instance against anonhostpi/obsidian-exposed-apis - 0.0.3-f (the tag that caused problems for #12)

src/util/GitHub.ts Outdated Show resolved Hide resolved
src/modals/PluginTroubleshootingModal.ts Outdated Show resolved Hide resolved
src/modals/PluginTroubleshootingModal.ts Outdated Show resolved Hide resolved
src/modals/PluginTroubleshootingModal.ts Outdated Show resolved Hide resolved
src/util/GitHub.ts Show resolved Hide resolved
@4Source 4Source added the patch label Jun 25, 2024
@4Source
Copy link
Owner

4Source commented Jun 25, 2024

Ready to ship?

@anonhostpi
Copy link
Contributor Author

Yup

@4Source 4Source merged commit eb0e64c into 4Source:master Jun 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong tag asset URL used in fetchManifest
2 participants