Skip to content

Commit

Permalink
Merge pull request #588 from 4dn-dcic/chip_duplicate_ctls
Browse files Browse the repository at this point in the history
Deduplicate control TAs in ChIP-seq input JSON
  • Loading branch information
clarabakker authored Jan 28, 2025
2 parents 8a8fd33 + aed8e68 commit 36077d0
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
8 changes: 8 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ foursight
Change Log
----------

4.9.10
=====

`PR 588: Deduplicate control TAs in ChIP-seq input JSON <https://github.com/4dn-dcic/foursight/pull/588>`_

* For ChIP-seq sets with 2+ identical control TA files, replace multi-file ctl list with one-item list


4.9.9
=====

Expand Down
4 changes: 4 additions & 0 deletions chalicelib_fourfront/checks/wfr_encode_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,10 @@ def rename_chip(input_at_id_list):
if ta_cnt:
s2_input_files['chip.ctl_tas'] = ta_cnt
s2_input_files['additional_file_parameters']['chip.ctl_tas'] = {"rename": rename_chip(ta_cnt)}
if len(set(ta_cnt)) == 1 and len(ta_cnt) != 1:
print("Control TAs are identical, listing file only once")
s2_input_files['chip.ctl_tas'] = [ta_cnt[0]]
s2_input_files['additional_file_parameters']['chip.ctl_tas'] = {"rename": rename_chip([ta_cnt[0]])}

# collect parameters
parameters = {}
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "foursight"
version = "4.9.9"
version = "4.9.10"
description = "Serverless Chalice Application for Monitoring"
authors = ["4DN-DCIC Team <[email protected]>"]
license = "MIT"
Expand Down

0 comments on commit 36077d0

Please sign in to comment.