Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action can remove pending lab external-lab #565

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Action can remove pending lab external-lab #565

merged 4 commits into from
Mar 27, 2024

Conversation

clarabakker
Copy link
Member

wrangler_checks/users_with_pending_lab check (and associated action):

  • defaults to WARN (rather than using PASS to indicate WARN)
  • removes external-lab from pending_lab as part of the action

@clarabakker clarabakker requested a review from aschroed March 25, 2024 19:19
@clarabakker
Copy link
Member Author

If the delete_field fails, is it okay to call the exception a "patch error"?

@aschroed
Copy link
Member

If the delete_field fails, is it okay to call the exception a "patch error"?

Sure. It is in fact a patch operation from the apps perspective.

@clarabakker clarabakker merged commit 436e26d into master Mar 27, 2024
1 check failed
@clarabakker clarabakker deleted the ignore_external_lab branch March 27, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschroed aschroed aschroed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clarabakker @aschroed