Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: date & timestamp type #7

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Apr 25, 2024

  1. support date & timestamp type
    you can use time.Time to represent SQL timestamp type, and openmldb.NullDate to represent date type
  2. simply mode in DSN
    only online & offline, and later option request, rm offsync or offasync
  3. deps: upgrade testify to v1.9.0

@aceforeverd aceforeverd added this to the v0.2 milestone Apr 25, 2024
@aceforeverd aceforeverd self-assigned this Apr 25, 2024
Timestamp is time.Time in go; and date is NullDate, a defined struct in
openmldb go sdk.
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 55.93220% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 57.75%. Comparing base (c046517) to head (ec47d14).

Files Patch % Lines
conn.go 62.06% 9 Missing and 2 partials ⚠️
types.go 50.00% 8 Missing and 2 partials ⚠️
driver.go 50.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   57.86%   57.75%   -0.11%     
==========================================
  Files           2        3       +1     
  Lines         159      187      +28     
==========================================
+ Hits           92      108      +16     
- Misses         51       61      +10     
- Partials       16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd aceforeverd force-pushed the feat-date-timestamp-type branch from 3a285fa to faefccf Compare April 25, 2024 08:19
@aceforeverd aceforeverd merged commit 49f51dd into 4paradigm:main Apr 26, 2024
1 check passed
@aceforeverd aceforeverd deleted the feat-date-timestamp-type branch April 26, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants