add whitespace check between interval literal and alias (#35)

fix 4paradigm/OpenMLDB#1208
4paradigm · Feb 17, 2022 · 3963378 · 3963378
1 parent b08253b
commit 3963378
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/zetasql/parser/flex_tokenizer.l b/zetasql/parser/flex_tokenizer.l
@@ -726,6 +726,12 @@ zone { return BisonParserImpl::token::KW_ZONE; }
     10s can be regarded as second interval literals which is equal to INTERVAL 10 SECOND. */
 {decimal_digits}[SMHD] {
   return BisonParserImpl::token::INTERVAL_LITERAL;
+}
+{decimal_digits}[SMHD][A-Z_] {
+  yylloc->begin.column += YYLeng() - 1;
+  SetOverrideError(
+      *yylloc, "Syntax error: Missing whitespace between literal and alias");
+  yyterminate();
 }
  /* Error rules for a number followed by an identifier without white space in
     between. We don't want to parse the identifier as accidental alias. For

diff --git a/zetasql/parser/testdata/literals.test b/zetasql/parser/testdata/literals.test
@@ -60,6 +60,20 @@ SELECT
   1d
 ==
 
+select 100ss
+--
+ERROR: Syntax error: Missing whitespace between literal and alias [at 1:12]
+select 100ss
+           ^
+==
+
+select 100DD
+--
+ERROR: Syntax error: Missing whitespace between literal and alias [at 1:12]
+select 100DD
+           ^
+==
+
 select 1e10, .1e10, 0.1e10, 1.e10, 1e+10, .1e-10, 0.1e+10, 1.e-10;
 --
 QueryStatement [0-65]