Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#Fixes 12862] Allow to add metadata when uploading a resource #902

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

ridoo
Copy link
Member

@ridoo ridoo commented Feb 4, 2025

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

kilichenko-pixida and others added 20 commits November 12, 2024 12:45
Bumps [django](https://github.com/django/django) from 4.2.9 to 4.2.16.
- [Commits](django/django@4.2.9...4.2.16)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…k for d… (GeoNode#12733)

* [Fixes GeoNode#12732] Asset file migration for documents does not work for document

* [Fixes GeoNode#12732] Asset file migration for documents does not work for document
even for a single file, the destination must be a list not a string
…be on tileset level (GeoNode#12764)

* [Fixes GeoNode#12763] 3D tiles geometricError mandatory field should be on tileset level

* [Fixes GeoNode#12763] 3D tiles geometricError mandatory field should be on tileset level

* [Fixes GeoNode#12763] 3D tiles geometricError mandatory field should be on tileset level
* Initial commit for the metadata architecture refactoring

* improving the code

* update the first handler

* rename the file of the main schema

* fixing manage.py

* For testing a specific folder for json schemas examples was created

* formatting the json schema files

* update the json schema examples

* adding the metadata/schema endpoint under api/v2

* rename the action of getting schema

* adding the metadata/instance/{pk} endpoint

* adding handlers registry

* update metadata manager

* update the metadata/{pk} to metadata/instance/{pk}

* update the /metadata/schema endpoint

* Handlers refactoring, i18n

* Add TKeywords subschema

* Metadata TKeywords: fix max card

* TKeywords: Fix schema

* Tkeywords: void get_jsonschema_instance

* TKeywords: Fix autocomplete; localization

* Thesaurus schema: Improve localization

* TKeywords: Improve autocomplete

* adding PUT functionality to the endpoint metadata/instance/{pk}

* rename the view of metadata/instance/{pk} endpoint

* TKeywords: Improve autocomplete

* TKeywords: move tkeywords just under category field

* Many improvements and addings to the base handler

* Some more improvements and addings to the base handler

* Return proper json schema instance

* Return proper json schema instance

* adding a handler for the regions field: RegionsHandler

* Add DOI handler

* Improvements and fixes

* fixing Region autocomplete

* Add DOI handler

* Simplify tkeywords schema

* adding serialize method to other FKs of the BaseHandler

* Extending PUT and removing serialization

* Fix PUT/PATCH

* Fixes: now patch returns without major errors

* Storing FKs to the resource model

* small improvements to store FK values

* TKeywords get and patch working. Added i18n to instance request

* Cleanup: black and flake

* Added contacts schema.
Moved tkeywords autocomplete.

* Load+store contacts

* Added linked resources handler

* Regions autocomplete

* Regions load/store

* Extending the Regions autocomplete results

* format fixing

* update the MetadataRegionsAutocomplete class

* Metadata: review label i18n

* Metadata: hkeywords handler - WIP

* Minor improvement

* Metadata: hkeywords handler

* Metadata: group handler

* Metadata: set owner fields as required

* Metadata: doi: implement update_resource

* Many improvements and fixes

Sparse fields, model + handler
Fix id type
Handling required fields
Add load_serialization_context
Add null type to most optional fields
Caching schema
Simplified handler registration

* Cleanup

* Add error handling, Improve sparse field loading

* Initial INSPIRE app

* May improvements: sparse fields, i18n,...

- Handling complex values in sparse fields
- Added i18n via thesaurus
- Improved subschema handling
- Renamed base schema json file

* tests for views

* adding more tests for views

* Tkeywords: hide property if no thesaurus configured

* Create test errors recursively

* Recurse localization in complex sparse fields

* Metadata: fix contact roles

* Metadata: improve handling of None values in sparse fields

* Metadata: add authorization to metadata access

* Metadata: fix required rolenames

* Metadata: improve type handling in sparse fields

* adding tests for views and manager

* Metadata: improve handling of None values in sparse fields

* Metadata: tentative handling of categories via autocomplete

* Metadata: tentative handling of categories via autocomplete

* adding base handlers tests

* Metadata: tentative handling of categories via autocomplete

* Metadata: handling licenses via autocomplete

* Black/flake

* Fix i18n caching

* adding more tests for the BaseHandler

* Fix flake

* Black/flake

* Metadata: fix group handling

* Metadata: fix FK handling

* adding tests for region and linkedrsources handers

* fixing tests

* black reformating

* adding tests and reformatting

* removing unused modules

* removing Permissions module

* adding tests for Group and Hkeyword handlers

* add a flake issue

* fixing views tsts

* adding tests for Contact and Thesaurus handlers and autocomplete views

* formatting issues

* adding tests for autocomplete views and Thesaurus handler

* adding tests for sparse handler

* fixing format issues

* Fix load_thesaurus

* Remove stale sample schemas

* Metadata: reload schema when labels on DB change

* Fix linked resources API

* Added __init__ to tests dir

* Fix UserHasPerms in views

* Remove geonode.inspire app

* Some improvements after review

* Delete unneeded migration

* Some improvements after review

* Metadata: show contact cardinalities only in debug mode

* Fix save: make proper signals work

---------

Co-authored-by: gpetrak <[email protected]>
* [Fixes GeoNode#12789] Improve 3dtiles filename handling

* [Fixes GeoNode#12789] Improve 3dtiles filename handling
add cmotadev to .clabot
* adding timeseries API

* fixing a bug

* black re-formatting

* Fix serializer for DatasetTimeSerie

* make some small improvements

* black reformatting

* improving the code

* formatting the code

* adding get_choices under the __init__ function of the serializer

* adding a support_time property

* update layers/views with the support_time property

* rename the property support_time to supports_time

* adding a get_choices property to the Dataset model and extending the supports_time property

* adding tests for the get_time_info function and for the supports_time property

* fixing a bug

* update the tests for the get_time_info

* removing non-used module

---------

Co-authored-by: Mattia <[email protected]>
…tcha on Login Form (GeoNode#12825) (GeoNode#12831)

* Add custom login view/template to support recaptcha on Login Form
* build(deps): bump django from 4.2.16 to 4.2.18

Bumps [django](https://github.com/django/django) from 4.2.16 to 4.2.18.
- [Commits](django/django@4.2.16...4.2.18)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix setup.cfg

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mattia <[email protected]>
…var (GeoNode#12849)

* disable gravatar provider

* fix hardcoded avatar urls in permspec tests

* fix hardcoded avatar urls in permspec tests (2)
@ridoo ridoo force-pushed the feature/12862_allow-to-add-metadata-when-uploading-a-resource branch 9 times, most recently from cfcd549 to b28b8cb Compare February 4, 2025 17:37
@ridoo ridoo force-pushed the feature/12862_allow-to-add-metadata-when-uploading-a-resource branch from b28b8cb to d1957c9 Compare February 5, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants