Adds the S10 and S10 Plus + Correct the data of OnePlus 6T and iPhone X + Device sorting by brand #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The landscape data was retrieved with the notch on the right (instead of on the left)
Thanks to the data provided by 5argon
06Games
changed the title
06Games
changed the title
|
I didn't know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Samsung S10 and S10+ thanks to the data collected in #2.
The landscape data of the iPhone X and the OnePlus 6T was obtained with the notch on the right, so the simulation didn't work properly.
And finally, the devices are now sorted by brand, which will facilitate the selection of devices in the future.